719022 - Digits-only file names get .css prefixed in front of postfixed

Status: VERIFIED FIXED

(DevTools :: Style Editor, defect, P2)

Description

[Alex Lakatos[:AlexLakatos]]

Digits-only file names get .css prefixed in front of postfixed

Steps to Reproduce
1.open the style editor
2.create a new style sheet
3.save it with a name with only digits, for example 1234.css

Actual results:
4.The stylesheet list shows css.1234

Expected results:
4.The stylesheet list shows 1234.css

Comment 1

[Paul Rouget [:paul]]

The problem is that we use `direction:rtl;` to simulate `XUL:crop=start` (part the Style Editor is in HTML).

To get rid of this workaround, I need to use a <xul:label>.

Comment 2

[Paul Rouget [:paul]]

Attachment: patch v1

Comment 3

[Paul Rouget [:paul]]

Attachment: patch v1.1

Comment 4

[Paul Rouget [:paul]]

(we will need a followup bug for the '*' not being display)

Comment 5

[Joe Walker [:jwalker]]

Comment on attachment 590800 [details] [diff] [review]
patch v1.1

Review of attachment 590800 [details] [diff] [review]:
-----------------------------------------------------------------

Does that mean we've lost the dirty * when a file is edited?

Comment 6

[Joe Walker [:jwalker]]

(In reply to Paul Rouget [:paul] from comment #4)
> (we will need a followup bug for the '*' not being display)

Ahh - missed this comment.

Comment 7

[Paul Rouget [:paul]]

https://hg.mozilla.org/integration/fx-team/rev/2d2a7c5534e3

Comment 8

[Paul Rouget [:paul]]

I will a? this patch once in central.

Comment 10

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/2d2a7c5534e3

Comment 11

[Cedric Vivier [:cedricv]]

Let's wait before a+ this.
The fix makes keyboard navigation in the list invisible.

Comment 12

[Cedric Vivier [:cedricv]]

Attachment: fix invisible outline for list keyboard navigation

Comment 13

[Paul Rouget [:paul]]

Comment on attachment 591531 [details] [diff] [review]
fix invisible outline for list keyboard navigation

Next time, please open a new bug.

Comment 14

[Paul Rouget [:paul]]

Well, it's a little tricky. Can you mark this bug as fixed and open a new bug?

Comment 15

[Paul Rouget [:paul]]

Comment on attachment 590800 [details] [diff] [review]
patch v1.1

[Approval Request Comment]
Regression caused by (bug #): New Feature. Not a regression.
User impact if declined: Some stylesheet will be spelled wrong.
Testing completed (on m-c, etc.): on m-c, local testing.
Risk to taking this patch (and alternatives if risky): low. Styling changes and one XUL tag added.

Comment 16

[Alex Keybl [:akeybl]]

Comment on attachment 590800 [details] [diff] [review]
patch v1.1

[Triage Comment]
Low risk fix in support of a new feature. Approved for Aurora.

Comment 17

[Paul Rouget [:paul]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/78d45f7defcd

Comment 18

[Virgil Dicu [:virgil] [QA]]

Mozilla/5.0 (X11; Linux x86_64; rv:12.0a2) Gecko/20120202 Firefox/12.0a2
Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20100101 Firefox/11.0

Verified using the steps from comment 0 on Ubuntu 11.10, Firefox 11 Beta 1 and Firefox Aurora (12). The file name is saved normally as "1234.css"