Closed Bug 719042 Opened 12 years ago Closed 12 years ago

Tilt should use the new Highlighter API

Categories

(DevTools :: Inspector, defect)

12 Branch
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 13

People

(Reporter: vporof, Assigned: vporof)

References

Details

(Whiteboard: [tilt])

Attachments

(1 file)

      No description provided.
Assignee: nobody → vporof
Status: NEW → ASSIGNED
Whiteboard: [tilt]
Attached patch v1Splinter Review
There is one line change in inspector.jsm.
I moved "this.highlighter.highlight();" before sending the OPENED notification, because when switching tabs, Tilt needs to call "this.highlighter.hide();". If this hide() call is made before the highlight() action, it won't have any effect because line 293 in highlighter.jsm: "if (this.hidden) return;". This means that the "hidden" flag isn't updated to false when the OPENED observer in Tilt calls hide(), which makes the highlighter always show above Tilt when switching tabs.
This behavior wasn't present before because I was setting the actual highlighter-container display to "none", a state which isn't modified by the highlighter internally.
Depends on: 715970
Blocks: 723435
Attachment #592519 - Flags: review?(rcampbell) → review+
Whiteboard: [tilt] → [tilt][land-in-fx-team]
https://hg.mozilla.org/integration/fx-team/rev/e71292cac3d2
Whiteboard: [tilt][land-in-fx-team] → [tilt][fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/e71292cac3d2
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Whiteboard: [tilt][fixed-in-fx-team] → [tilt]
Target Milestone: --- → Firefox 13
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: