719309 - Disable touch events widget code

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Wesley Johnston (:wesj)]

Attachment: Patch

Touch events are almost ready, but the widget code needs some... tweaking to deal correctly with asynchronous scrolling. To make things a bit easier to work on, we'd like to land them preffed off for now and file individual bugs for follow up work.

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 589749 [details] [diff] [review]
Patch

"sendTouchEvents" -> "touchEventsEnabled"

* I assume this does not mess up GeckoPreferences gecko listener for Preference:Data
* We should probably remove this code once touch events are working well enough. I don't think we want to keep this capability.

Comment 2

[Wesley Johnston (:wesj)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/bfa8aedbff44

Just realized I forgot to change this name. I'll push a follow up...

Comment 3

[Wesley Johnston (:wesj)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ba99528f5f11 - variable rename

Comment 4

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/bfa8aedbff44
https://hg.mozilla.org/mozilla-central/rev/ba99528f5f11

Comment 5

[Brad Lassey [:blassey] (use needinfo?)]

Wes, please request aurora approval

Comment 6

[Wesley Johnston (:wesj)]

Comment on attachment 589749 [details] [diff] [review]
Patch

User impact if declined: Needed to keep multitouch moving forward
Testing completed (on m-c, etc.): on mc since 1/24
Risk to taking this patch (and alternatives if risky): Low risk. Mobile only. Only disables new code.

Comment 7

[Wesley Johnston (:wesj)]

https://hg.mozilla.org/releases/mozilla-beta/rev/f5e015526fde

Comment 8

[Wesley Johnston (:wesj)]

https://hg.mozilla.org/releases/mozilla-beta/rev/fffeb5ffd845