Closed
Bug 719538
Opened 12 years ago
Closed 12 years ago
use nsIWindowsRegKey in Windows shell service
Categories
(Firefox :: Shell Integration, defect)
Tracking
()
RESOLVED
FIXED
Firefox 12
People
(Reporter: Gavin, Assigned: Gavin)
References
Details
Attachments
(1 file, 1 obsolete file)
5.81 KB,
patch
|
jimm
:
review+
|
Details | Diff | Splinter Review |
...instead of calling the registry APIs directly
Assignee | ||
Comment 1•12 years ago
|
||
Comment 2•12 years ago
|
||
Comment on attachment 589939 [details] [diff] [review] patch Review of attachment 589939 [details] [diff] [review]: ----------------------------------------------------------------- ::: browser/components/shell/src/nsWindowsShellService.cpp @@ +785,5 @@ > + nsIWindowsRegKey::ACCESS_SET_VALUE); > + NS_ENSURE_SUCCESS(rv, rv); > + > + char rgb[12]; > + sprintf((char*)rgb, "%u %u %u\0", r, g, b); Couldn't we print this into a PRUnichar buf and skip the use of NS_ConvertUTF8toUTF16 all together?
Attachment #589939 -
Flags: review?(jmathies) → review+
Assignee | ||
Comment 3•12 years ago
|
||
please double check my _snwprintfing!
Attachment #589977 -
Flags: review?(jmathies)
Comment 4•12 years ago
|
||
Comment on attachment 589977 [details] [diff] [review] patch look ok to me!
Attachment #589977 -
Flags: review?(jmathies) → review+
Assignee | ||
Updated•12 years ago
|
Attachment #589939 -
Attachment is obsolete: true
Assignee | ||
Comment 5•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/eb09304af438
Target Milestone: --- → Firefox 12
Comment 6•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/eb09304af438
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•