Closed Bug 719575 Opened 12 years ago Closed 12 years ago

gfx broke my clang builds

Categories

(Core :: Graphics, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla12

People

(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)

References

Details

Attachments

(1 file)

/Users/ehsanakhgari/moz/oak/gfx/skia/src/effects/SkGradientShader.cpp:1998:17: warning: unused function 'atan_0_90' [-Wunused-function]
static unsigned atan_0_90(SkFixed y, SkFixed x) {
                ^
1 warning generated.
/Users/ehsanakhgari/moz/oak/gfx/skia/src/ports/SkFontHost_mac_coretext.cpp:799:28: error: non-constant-expression cannot be narrowed from type 'CGFloat' (aka 'double') to 'SkScalar' (aka 'float') in initializer list
    const SkPoint trans = {SkFloatToScalar(vertOffset.width),
                           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/Users/ehsanakhgari/moz/oak/gfx/skia/include/core/SkScalar.h:111:37: note: expanded from:
    #define SkFloatToScalar(n)      (n)
                                    ^~~
/Users/ehsanakhgari/moz/oak/gfx/skia/src/ports/SkFontHost_mac_coretext.cpp:799:28: note: override this message by inserting an explicit cast
    const SkPoint trans = {SkFloatToScalar(vertOffset.width),
                           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/Users/ehsanakhgari/moz/oak/gfx/skia/include/core/SkScalar.h:111:37: note: expanded from:
    #define SkFloatToScalar(n)      (n)
                                    ^~~
/Users/ehsanakhgari/moz/oak/gfx/skia/src/ports/SkFontHost_mac_coretext.cpp:800:28: error: non-constant-expression cannot be narrowed from type 'CGFloat' (aka 'double') to 'SkScalar' (aka 'float') in initializer list
                           SkFloatToScalar(vertOffset.height)};
                           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/Users/ehsanakhgari/moz/oak/gfx/skia/include/core/SkScalar.h:111:37: note: expanded from:
    #define SkFloatToScalar(n)      (n)
                                    ^~~
/Users/ehsanakhgari/moz/oak/gfx/skia/src/ports/SkFontHost_mac_coretext.cpp:800:28: note: override this message by inserting an explicit cast
                           SkFloatToScalar(vertOffset.height)};
                           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/Users/ehsanakhgari/moz/oak/gfx/skia/include/core/SkScalar.h:111:37: note: expanded from:
    #define SkFloatToScalar(n)      (n)
                                    ^~~
2 errors generated.
Attached patch Patch (v1)Splinter Review
Assignee: nobody → ehsan
Status: NEW → ASSIGNED
Attachment #589973 - Flags: review?(matt.woodrow)
Blocks: clang-macosx
Attachment #589973 - Flags: review?(matt.woodrow) → review+
https://hg.mozilla.org/mozilla-central/rev/26998c1affd1
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: