719731 - Get rid of window mediator's getMostRecentBrowserWindow across Tilt codebase

Status: RESOLVED FIXED

(DevTools :: Inspector, defect)

Description

[Victor Porof [:vporof][:vp]]

Because it's redundant.

Comment 1

[Victor Porof [:vporof][:vp]]

Attachment: v1

Comment 2

[Rob Campbell [:rc] (:robcee)]

which bug does this depend on?

Comment 3

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 590164 [details] [diff] [review]
v1

+ * @param {Window} aChromeWindow
+ *                 the top-level browser window
+ *
  * @param {Number} the zoom ammount
  */
-TiltUtils.setDocumentZoom = function TU_getDocumentZoom(aZoom) {
-  TiltUtils.getBrowserWindow()
-           .gBrowser.selectedBrowser.markupDocumentViewer.fullZoom = aZoom;
+TiltUtils.setDocumentZoom = function TU_setDocumentZoom(aChromeWindow, aZoom) {
+  aChromeWindow.gBrowser.selectedBrowser.markupDocumentViewer.fullZoom = aZoom;
 };


I thought we were going to do this:
  /**
   * Store page zoom factor.
   */
  computeZoomFactor: function Highlighter_computeZoomFactor() {
    this.zoom =
      this.win.QueryInterface(Components.interfaces.nsIInterfaceRequestor)
      .getInterface(Components.interfaces.nsIDOMWindowUtils)
      .screenPixelsPerCSSPixel;
  },

for that.

I bet that's in another patch, isn't it.

Comment 4

[Victor Porof [:vporof][:vp]]

(In reply to Rob Campbell [:rc] (robcee) from comment #3)
> I bet that's in another patch, isn't it.

Yup, bug 719877.

Comment 5

[Rob Campbell [:rc] (:robcee)]

https://hg.mozilla.org/integration/fx-team/rev/e4216a369836

Comment 6

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/e4216a369836