719845 - [markup panel] The HTML Tree should have its own keybindings

Status: RESOLVED FIXED

(DevTools :: Inspector, defect, P3)

Description

[Paul Rouget [:paul]]

The keybindings in the inspector map the layout of the Breadcrumbs (left for parent node for example). The HTML Tree has a different layout, and some keybindings don't make sense.

Up and Down should select the next line in the tree. Even if the line is a closing tag.
Left and Right should Close and Open the current Node.

Comment 2

[Rob Campbell [:rc] (:robcee)]

(In reply to Paul Rouget [:paul] from bug 754661 comment #4)
> iirc, we had to disable the shortcut because they were messing with the
> other highlighter shortcuts, and they were confusing (up and down to visit
> the parent and descendants, right and left to visit the siblings).

Not confusing for users of Firebug. I think it's fairly standard tree-view navigation for left/right to close and open tree-items and up down to navigate. Maybe that's made confusing because of the breadcrumb navigation keys.

Comment 3

[Paul Rouget [:paul]]

(In reply to Rob Campbell [:rc] (:robcee) from comment #2)
> (In reply to Paul Rouget [:paul] from bug 754661 comment #4)
> > iirc, we had to disable the shortcut because they were messing with the
> > other highlighter shortcuts, and they were confusing (up and down to visit
> > the parent and descendants, right and left to visit the siblings).
> 
> Not confusing for users of Firebug. I think it's fairly standard tree-view
> navigation for left/right to close and open tree-items and up down to
> navigate. Maybe that's made confusing because of the breadcrumb navigation
> keys.

Yes. And we should implement this behavior. But that is not what we got in the tree view.

Before:
* up/down, visit siblings;
* right/left, visit parents/descendants.

Firebug (and what we should implement):
* up/down, visit the previous (or next) element in the tree (like a cursor);
* left/right, fold/unfold a node.

We should use these shortcuts as soon as the treeview is open (even if not focused).

Comment 4

[Dave Camp (:dcamp)]

Attachment: WIP

This patch implements the keybindings if the tree is focused.  But I think agree with paul, that they should be true if the html panel is open at all.

Also doesn't have tests, but I don't want to lose this patch.

Comment 5

[Paul Rouget [:paul]]

Attachment: v1

Comment 6

[Paul Rouget [:paul]]

https://hg.mozilla.org/integration/fx-team/rev/28473532325e

Comment 7

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/28473532325e