719873 - All use of render_to_string that don't need `request` shouldn't ask for it

Status: RESOLVED FIXED

(Webtools Graveyard :: Elmo, defect)

Description

[Peter Bengtsson [:peterbe]]

Functions inside views.py files that take `request` as a first positional argument might appear like Django view functions but they're not and should therefore not use RequestContext if they don't actually need it. ``import this``

Comment 1

[Peter Bengtsson [:peterbe]]

Attachment: render_to_string functions refactored

Comment 2

[Axel Hecht [:Pike]]

Comment on attachment 590361 [details] [diff] [review]
render_to_string functions refactored

Review of attachment 590361 [details] [diff] [review]:
-----------------------------------------------------------------

r=me, with the removal of the l10nstats snippet call, or that as a follow up bug.

::: apps/homepage/views.py
@@ +111,4 @@
>          return redirect('homepage.views.teams')
>  
>      from l10nstats.views import teamsnippet as stats_snippet
> +    l10nstats_div = mark_safe(stats_snippet(loc))

I think we should really just drop calling in to this at all. The new team page doesn't use this div.

Fine as a follow-up though.

Comment 3

[Peter Bengtsson [:peterbe]]

https://github.com/mozilla/elmo/commit/3ce2de65fcefdf45f67b903e0a05d37ba0ceb2f5