Closed
Bug 720142
Opened 12 years ago
Closed 12 years ago
Use nsIntRect for table damage
Categories
(Core :: Layout: Tables, defect)
Core
Layout: Tables
Tracking
()
RESOLVED
FIXED
mozilla12
People
(Reporter: MatsPalmgren_bugz, Assigned: MatsPalmgren_bugz)
References
Details
Attachments
(3 files)
60.13 KB,
patch
|
bernd_mozilla
:
review+
|
Details | Diff | Splinter Review |
2.32 KB,
patch
|
bernd_mozilla
:
review+
|
Details | Diff | Splinter Review |
1.69 KB,
patch
|
bernd_mozilla
:
review+
|
Details | Diff | Splinter Review |
nsRect is for areas in app units and it uses nscoord which may not be PRInt32 in the future. We should propagate table damage using nsIntRect to prevent mistakes and to make the code somewhat more future proof. Arguably, we should a distinct type (eg TableDamageRect) to avoid the mistake of passing a nsIntRect in pixel coordinates, but nsIntRect isn't all that common on layout code so doesn't seem worth the effort right now.
Assignee | ||
Comment 1•12 years ago
|
||
Attachment #590490 -
Flags: review?(bernd_mozilla)
Assignee | ||
Comment 2•12 years ago
|
||
Attachment #590491 -
Flags: review?(bernd_mozilla)
Assignee | ||
Comment 3•12 years ago
|
||
Attachment #590492 -
Flags: review?(bernd_mozilla)
Assignee | ||
Comment 4•12 years ago
|
||
That's all for this bug.
Attachment #590490 -
Flags: review?(bernd_mozilla) → review+
Attachment #590491 -
Flags: review?(bernd_mozilla) → review+
Attachment #590492 -
Flags: review?(bernd_mozilla) → review+
Assignee | ||
Comment 5•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/67fb425e004b https://hg.mozilla.org/integration/mozilla-inbound/rev/d65285b04917 https://hg.mozilla.org/integration/mozilla-inbound/rev/ee922e0041e1
Whiteboard: [inbound]
Target Milestone: --- → mozilla12
Comment 6•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/67fb425e004b https://hg.mozilla.org/mozilla-central/rev/d65285b04917 https://hg.mozilla.org/mozilla-central/rev/ee922e0041e1
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
You need to log in
before you can comment on or make changes to this bug.
Description
•