720154 - Checkbox for restore_on_demand should always be accessible

Status: RESOLVED FIXED

(Firefox :: Settings UI, enhancement)

Description

[Siddhartha Dugar [:sdrocking]]

Bug 648683 allows users to enable restore_on_demand when they choose "Show my windows and tabs from last time" for Firefox startup. This should always be accessible irrespective of the users selection in the other menu. A user may need to restart Firefox for an update or an addon installation and may not want to restore all tabs.

Comment 1

[Ioana (away)]

Dugar, this issue seems to be an enhancement request rather than a bug. Please mark it correspondingly.

Comment 2

[Ioana (away)]

Sorry, the version got changed accidentally.

Comment 3

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

Yea, that's probably a good idea. It sort of made sense when I first did it but now I'm less sure. Let's see what UX says - Limi, can you comment?

Comment 4

[Siddhartha Dugar [:sdrocking]]

Changing importance to "enhancement" as requested.

Comment 5

[Alex Limi (:limi) — Firefox UX Team]

(In reply to Paul O'Shannessy [:zpao] from comment #3)
> Yea, that's probably a good idea. It sort of made sense when I first did it
> but now I'm less sure. Let's see what UX says - Limi, can you comment?

Sounds good, and it should probably be relocated to the Tabs page in that case. 

(I wonder if people will expect us to not load tabs opened in the background if we do that, but it seems like something that wouldn't make a lot of sense, maybe I'm overthinking it :)

Comment 8

[Danial Horton]

was about to create this exact artifact.

This setting as it is, us slightly ineffective for several reasons.

1. A user might not choose to have firefox configured to load the last session when starting a new session, but will use an extension or the add=on manager to restart the browser either for a fresh start or extension updates, which will generally reload with the same tabs as prior to the restart.

In this case, the user may expect all tabs to reload.

2. Session managers:  a user would probably expect all tabs to reload in the case of loading a saved session, not all of them have a setting in their options to disable reload on demand (Session Manager does)

Comment 9

[Matthew N. [:MattN]]

We'll move the checkbox to the tabs page then.  Note that the same change needs to be made in two places since we are porting to in-content preferences:

browser/components/preferences and
browser/components/preferences/in-content (for when browser.preferences.inContent = true)

Comment 10

[Andrew Hurle [:ahurle]]

Attachment: v1 - Move checkbox to Tabs page

Comment 11

[Dão Gottwald [:dao]]

Comment on attachment 624238 [details] [diff] [review]
v1 - Move checkbox to Tabs page

Please rename restoreOnDemand.* to restoreTabsOnDemand.*

Comment 12

[Andrew Hurle [:ahurle]]

Attachment: v2 - restoreOnDemand.* renamed to restoreTabsOnDemand.*

Comment 13

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

Comment on attachment 624438 [details] [diff] [review]
v2 - restoreOnDemand.* renamed to restoreTabsOnDemand.*

I know Limi said we should do this and on the surface it all looks good. But I'd like to get somebody from UX to chime in and see if we should reword the string now that it doesn't have the same context.

Comment 14

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

Attachment: screenshot

Poking Boriss for ui-review since she ui-r'ed the original string.

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2a027b72537a

Comment 16

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/2a027b72537a

Comment 17

[Mardeg]

(In reply to Paul O'Shannessy [:zpao] (not reading much bugmail, email directly) from comment #13)
> I'd like to get somebody from UX to chime in and see if we should reword the
> string now that it doesn't have the same context.
Because bug 792210 has yet to be fixed, users expect this option in its new "Tabs" location to prevent loading of background tabs opened via 'Open All in Tabs' bookmarks subfolder context menu (bug 851775) and when just middle-clicking/Apple-clicking many links to open them in background tabs (bug 911427).