Closed
Bug 720341
Opened 12 years ago
Closed 12 years ago
Fix error downloading Test Pilot tests and fix the endless "Loading, please wait..." message
Categories
(Thunderbird :: General, defect)
Thunderbird
General
Tracking
(thunderbird10+ fixed, thunderbird11+ fixed)
RESOLVED
FIXED
Thunderbird 12.0
People
(Reporter: standard8, Assigned: standard8)
Details
Attachments
(1 file)
1.99 KB,
patch
|
mconley
:
review+
standard8
:
approval-comm-aurora+
standard8
:
approval-comm-beta+
|
Details | Diff | Splinter Review |
Fixing two issues in one patch here as its easiest and they were resolved together. First: Error: no element found Source file: https://testpilot.mozillalabs.com/testcases/index-tb.json Line: 1 This is generated because the xml parser thinks its getting a .html file not a plain text file, we can force this formatting server side or client side, but I've chosen server side for now. Second: When test pilot hasn't got any studies listed in index-tb.json (like is currently the case), it displays "Loading, please wait" in the list of studies forever. I've found this to be a bogus check for zero length on the list of studies. I've checked this with Jono and he thinks it is fine to remove that check.
Attachment #590672 -
Flags: review?(mconley)
Assignee | ||
Updated•12 years ago
|
tracking-thunderbird10:
--- → +
tracking-thunderbird11:
--- → +
Comment 1•12 years ago
|
||
Comment on attachment 590672 [details] [diff] [review] The fix Looks reasonable to me!
Attachment #590672 -
Flags: review?(mconley) → review+
Assignee | ||
Comment 2•12 years ago
|
||
Checked in: http://hg.mozilla.org/comm-central/rev/a049f0583298
Assignee: nobody → mbanner
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 12.0
Assignee | ||
Updated•12 years ago
|
Attachment #590672 -
Flags: approval-comm-beta+
Attachment #590672 -
Flags: approval-comm-aurora+
Assignee | ||
Updated•12 years ago
|
Attachment #590672 -
Flags: approval-comm-beta+
Assignee | ||
Comment 3•12 years ago
|
||
Checked into branches: http://hg.mozilla.org/releases/comm-aurora/rev/ba2f0d434933 http://hg.mozilla.org/releases/comm-beta/rev/9470da684c06
Assignee | ||
Updated•12 years ago
|
status-thunderbird10:
--- → fixed
status-thunderbird11:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•