Closed
Bug 720354
Opened 12 years ago
Closed 12 years ago
Drop unused MSG_FASTER_URI_PARSING code
Categories
(MailNews Core :: Backend, defect)
MailNews Core
Backend
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 12.0
People
(Reporter: standard8, Assigned: aceman)
References
()
Details
Attachments
(1 file)
|
3.76 KB,
patch
|
standard8
:
review+
|
Details | Diff | Splinter Review |
No functional change, just drop some unused code that we've never used. See the url for details. It also gets rid of a static nsCOMPtr instance, that although its unused, shouldn't be there anyway (bug 467356). Aceman, want to pick this up?
If I understand this correctly, the code is ifdefed in MSG_FASTER_URI_PARSING, but that is newer defined, so the code is dead. If that is true then I can take this. But I do not understand the relation to bug 467356. Should I wait on that bug to get resolved first? Or with I actually do part of the work that bug 467356 should have done?
Assignee: nobody → acelists
|
Reporter | |
Comment 2•12 years ago
|
||
(In reply to :aceman from comment #1) > If I understand this correctly, the code is ifdefed in > MSG_FASTER_URI_PARSING, but that is newer defined, so the code is dead. If > that is true then I can take this. Correct. > But I do not understand the relation to bug 467356. Should I wait on that > bug to get resolved first? Or with I actually do part of the work that bug > 467356 should have done? You're doing part of the work that bug 467356 would have done.
Attachment #590833 -
Flags: review?(mbanner)
|
|
Reporter | |
Updated•12 years ago
|
Attachment #590833 -
Flags: review?(mbanner) → review+
Keywords: checkin-needed
|
|
Reporter | |
Comment 4•12 years ago
|
||
Checked in: http://hg.mozilla.org/comm-central/rev/d58e5898881d
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Flags: in-testsuite-
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 12.0
You need to log in
before you can comment on or make changes to this bug.
Description
•