720408 - Exception handling message "Tab:ScreenshotData": java.lang.StringIndexOutOfBoundsException

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect, P2)

Description

[Aaron Train [:aaronmt]]

Attachment: Raw log (Nightly 01/23)

I/GeckoApp( 3910): Got message: Tab:ScreenshotData
E/GeckoApp( 3910): Exception handling message "Tab:ScreenshotData":
E/GeckoApp( 3910): java.lang.StringIndexOutOfBoundsException: length=6; index=22
E/GeckoApp( 3910): 	at java.lang.String.indexAndLength(String.java:589)
E/GeckoApp( 3910): 	at java.lang.String.substring(String.java:1448)
E/GeckoApp( 3910): 	at org.mozilla.gecko.GeckoApp.handleMessage(GeckoApp.java:924)
E/GeckoApp( 3910): 	at org.mozilla.gecko.GeckoAppShell.handleGeckoMessage(GeckoAppShell.java:1616)
E/GeckoApp( 3910): 	at org.mozilla.gecko.GeckoAppShell.nativeRun(Native Method)
E/GeckoApp( 3910): 	at org.mozilla.gecko.GeckoAppShell.nativeRun(Native Method)
E/GeckoApp( 3910): 	at org.mozilla.gecko.GeckoAppShell.runGecko(GeckoAppShell.java:483)
E/GeckoApp( 3910): 	at org.mozilla.gecko.GeckoThread.run(GeckoThread.java:104)


--
Samsung Nexus S (Android 4.0.3)
Mozilla/5.0 (Android; Linux armv7l; rv:12.0a1) Gecko/20120123 Firefox/12.0a1 Fennec/12.0a1

Comment 1

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: patch

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 592984 [details] [diff] [review]
patch

Why would we get into this state? Is an empty string coming back?

If you know, can you add a comment above the new if check?

Comment 3

[Brad Lassey [:blassey] (use needinfo?)]

(In reply to Mark Finkle (:mfinkle) from comment #2)
> Comment on attachment 592984 [details] [diff] [review]
> patch
> 
> Why would we get into this state? Is an empty string coming back?
> 
> If you know, can you add a comment above the new if check?

not an empty string, but looks like empty data from the log. I suspect that getting the data from the canvas failed (possibly because drawing to it failed) and we're just getting a string with "data:".

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/396945d35979

Comment 5

[Brad Lassey [:blassey] (use needinfo?)]

Comment on attachment 592984 [details] [diff] [review]
patch

[Approval Request Comment]
Regression caused by (bug #): 
User impact if declined: 
Low volume crash from unknown cause. We weren't able to reproduce
Testing completed (on m-c, etc.): 
Risk to taking this patch (and alternatives if risky):
String changes made by this patch:

Comment 6

[Alex Keybl [:akeybl]]

Comment on attachment 592984 [details] [diff] [review]
patch

[Triage Comment]
Mobile only - approved for Aurora 12 and Beta 11.

Comment 7

[Doug Turner (:dougt)]

https://hg.mozilla.org/releases/mozilla-beta/rev/51389da3984a

Comment 8

[Mark Finkle (:mfinkle) (use needinfo?)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/cc433916cd1d