Closed Bug 720442 Opened 12 years ago Closed 12 years ago

When scrolling input fields into view, scroll them to just above keyboard instead of top of screen

Categories

(Firefox for Android Graveyard :: General, defect, P2)

Product:
Firefox for Android Graveyard
Component:
General
Platform:
All
Android
Type:
defect

Tracking

(firefox11 fixed, firefox12 fixed, fennec11+)

Status:
VERIFIED FIXED
Milestone:
Firefox 12
Tracking Flags:
Tracking Status
firefox11 --- fixed
firefox12 --- fixed
fennec 11+ ---

People

(Reporter: kats, Assigned: kats)

References

Details

Attachments

(1 file)

Simplest patch ever
1.26 KB, patch
blassey
: review+
akeybl
: approval-mozilla-aurora+
Details | Diff | Splinter Review 
      No description provided.
tracking-fennec: ? → 11+
Priority: -- → P2
Tested manually using http://people.mozilla.org/~kgupta/bug/696319.html and random web content
Attachment #591812 - Flags: review?(blassey.bugs)
Comment on attachment 591812 [details] [diff] [review]
Simplest patch ever

Review of attachment 591812 [details] [diff] [review]:
-----------------------------------------------------------------

well... that was easy :-)
Attachment #591812 - Flags: review?(blassey.bugs) → review+
https://hg.mozilla.org/mozilla-central/rev/5eb7ad98588a
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Comment on attachment 591812 [details] [diff] [review]
Simplest patch ever

[Approval Request Comment]
Regression caused by (bug #): none
User impact if declined: input fields get scrolled to top of viewport which can be annoying
Testing completed (on m-c, etc.): on m-c
Risk to taking this patch (and alternatives if risky): mobile only
Attachment #591812 - Flags: approval-mozilla-aurora?
Comment on attachment 591812 [details] [diff] [review]
Simplest patch ever

[Triage Comment]
Mobile only - approved for Aurora.
Attachment #591812 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Verified fixed on

Aurora: Mozilla /5.0 (Android;Linux armv7l;rv:11.0a2) Gecko/20120131 Firefox/11.0a2 Fennec/11.0a2
Nightly: Mozilla /5.0 (Android;Linux armv7l;rv:12.0a1) Gecko/20120201 Firefox/12.0a1 Fennec/12.0a1

Device: LG Optimus 2X (Android 2.2)
Status: RESOLVED → VERIFIED
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: