720647 - Add message managers to black-bit-propagation

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Olli Pettay [:smaug][[e-mail]]]

Attachment: patch

This code will be used by nsCCUncollectableMarker::Observe.

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 591047 [details] [diff] [review]
patch

Er, this is only partial patch. Uploading a new one in a minute.

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 591047 [details] [diff] [review]
patch

Actually this is ok. I'll move some other stuff to nsCCUncollectableMarker

Comment 3

[Andrew McCreight [:mccr8]]

Did you mean to make nsIInProcessContentFrameMessageManager builtinclass? You changed the UUID but didn't do anything else to that class.

Comment 4

[Andrew McCreight [:mccr8]]

Looks reasonable to me, though I still don't like how you are doing the unmark gray on the XPCWrappedJS here. ;)  But let's hash that out in bug 720536.

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

(In reply to Andrew McCreight [:mccr8] from comment #3)
> Did you mean to make nsIInProcessContentFrameMessageManager builtinclass?
> You changed the UUID but didn't do anything else to that class.
It isn't a scriptable interface, so builtinclass doesn't really matter, and uuid is changed
by the script which changes uuids in all the interfaces which inherit an interface which got
changed.

Comment 6

[Andrew McCreight [:mccr8]]

Ah, okay, that makes sense.  I figured there was a reason, I just wasn't sure what it was.

Comment 7

[Andrew McCreight [:mccr8]]

Comment on attachment 591047 [details] [diff] [review]
patch

Review of attachment 591047 [details] [diff] [review]:
-----------------------------------------------------------------

r=me if you revert the xpcprivate.h include and replace the if block as described below.

::: content/base/src/nsFrameMessageManager.cpp
@@ +1117,5 @@
> +  PRUint32 len = mListeners.Length();
> +  for (PRUint32 i = 0; i < len; ++i) {
> +    nsCOMPtr<nsIXPConnectWrappedJS> wjs =
> +      do_QueryInterface(mListeners[i].mListener);
> +    if (wjs) {

I assume you will replace this whole "if (wjs) { ... }" block with just "xpc_UnmarkGrayObject(wjs);" as per the other bugs.

Comment 8

[Olli Pettay [:smaug][[e-mail]]]

Yup. I have that already fixed locally.

Comment 9

[Olli Pettay [:smaug][[e-mail]]]

Attachment: patch

Comment 10

[Olli Pettay [:smaug][[e-mail]]]

Attachment: patch

Comment 11

[Olli Pettay [:smaug][[e-mail]]]

https://hg.mozilla.org/mozilla-central/rev/85b19db37fd0