720663 - devicemanagerADB pushDir fallback doesn't always work

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Chris Lord [:cwiiis]]

On both my devices, running the reftest-remote target (as described here: https://wiki.mozilla.org/Mobile/Fennec/Android#Reftests) fails due to unzip not being present on the device (or not working). The current devicemanagerADB.py script fails to detect this and bails out, but the fallback path works fine.

Comment 1

[Chris Lord [:cwiiis]]

Attachment: Fix devicemanagerADB.py pushDir fallback

This patch allows me to run reftests locally by making sure the fallback path is always tried before bailing out.

Comment 2

[Geoff Brown [:gbrown]]

Comment on attachment 591061 [details] [diff] [review]
Fix devicemanagerADB.py pushDir fallback

Review of attachment 591061 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks Chris - that's a good change. 

Out of curiosity, what was causing the exception for you?

Comment 3

[Chris Lord [:cwiiis]]

Not sure what the error was, my python foo isn't good enough and I can't quickly find any documentation for the CalledProcessError object...

That said, I think it was just that the device doesn't have an unzip binary.

Pushed to inbound: http://hg.mozilla.org/integration/mozilla-inbound/rev/63db726e7634

Comment 4

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/63db726e7634