720786 - ldap autocomplete errors caused by backspacing

Status: NEW

(Thunderbird :: Message Compose Window, defect)

Description

[:Irving Reid (No longer working on Firefox)]

OK, finally got this built on TB 10 (Beta) and it's working OK, though I did notice one quirk - at one point, as I was changing what was typed in the To: address box, TB threw a couple of assertion fail messages:

###!!! ASSERTION: We don't know what went wrong with the ldap operation: 'Error', file /Users/ireid/tbird/comm-beta/ldap/xpcom/src/nsLDAPConnection.cpp, line 704
###!!! ASSERTION: Failed to shutdown thread cleanly: '!mThread || NS_SUCCEEDED(mThread->Shutdown())', file /Users/ireid/tbird/comm-beta/ldap/xpcom/src/nsLDAPConnection.cpp, line 241


It appears to happen pretty reliably if I backspace medium-quickly (like 0.25 seconds or so) after entering an address prefix, like:

bsmi (autocomplete suggestions show up) <backspace><backspace><backspace>

If I time it so I hit backspace just before the next set of autocomplete results show, I get the assertion failure. TB recovers and displays the correct autocomplete for whatever is left in the address box, so I'm guessing that we're just not quite doing the right thing to cancel an in-progress search before we start the next one.

...

Went hunting through bugzilla to see if anyone had reported the "We don't know what went wrong" assertion, and when I came back to my TB client, my autocomplete is now completely broken with:

###!!! ASSERTION: nsLDAPAutoCompleteSession::DoTask(): couldn't initialize LDAP operation: 'Error', file /Users/ireid/tbird/comm-beta/mailnews/addrbook/src/nsLDAPAutoCompleteSession.cpp, line 576

My suspicion with this is that the underlying TCP connection has timed out and closed, and we're not re-opening it correctly. Closing the compose window or switching to the address book and doing a search there, makes the "couldn't initialize" error go away.

Here are some other errors logged as I was reproducing this issue:

###!!! ASSERTION: We don't know what went wrong with the ldap operation: 'Error', file /Users/ireid/tbird/comm-beta/ldap/xpcom/src/nsLDAPConnection.cpp, line 704
###!!! ASSERTION: nsLDAPOperation::AbandonExt(): mMessageListener or mMsgId not initialized: 'Error', file /Users/ireid/tbird/comm-beta/ldap/xpcom/src/nsLDAPOperation.cpp, line 550
WARNING: nsLDAPAutoCompleteSession::OnStopLookup(): error calling mOperation->AbandonExt(): file /Users/ireid/tbird/comm-beta/mailnews/addrbook/src/nsLDAPAutoCompleteSession.cpp, line 265
###!!! ASSERTION: We don't know what went wrong with the ldap operation: 'Error', file /Users/ireid/tbird/comm-beta/ldap/xpcom/src/nsLDAPConnection.cpp, line 704
WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80590051: file /Users/ireid/tbird/comm-beta/ldap/xpcom/src/nsLDAPOperation.cpp, line 504

Comment 1

[Wayne Mery (:wsmwk)]

irving, I doubt there are many users who would know if they got assertions :)

but there are other autocomplete problems reported, like Bug 368025 and Bug 103426, and by extension Bug 116702 

is your issue a new one, not repeatable on prior versions?