720795 - Screen orientation API reading and event implementation in Android

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Mounir Lamouri (:mounir)]

Attachment: Patch

Comment 1

[Doug Turner (:dougt)]

Comment on attachment 591218 [details] [diff] [review]
Patch

Review of attachment 591218 [details] [diff] [review]:
-----------------------------------------------------------------

::: embedding/android/GeckoScreenOrientationListener.java
@@ +106,5 @@
> +      mOrientation = eScreenOrientation_LandscapeSecondary;
> +    } else if (rotation == Surface.ROTATION_90) {
> +      mOrientation = eScreenOrientation_LandscapePrimary;
> +    } else {
> +      Log.e("GeckoScreenOrientationListener", "Unexpected value received! (" + rotation + ")");

i think you just should return early

Comment 2

[Mounir Lamouri (:mounir)]

Comment on attachment 591218 [details] [diff] [review]
Patch

Pushed with the early return.

Comment 3

[Ed Morley [:emorley]]

Backed out of inbound for build failures on all platforms:
https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=4a763183482f

https://hg.mozilla.org/integration/mozilla-inbound/rev/c4c7eaaeec91

Comment 4

[Ed Morley [:emorley]]

Relanded, but the push had to be backed out again for bustage:
https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=1ca8d5a931ac

https://hg.mozilla.org/integration/mozilla-inbound/rev/33ffd55f2dfe

Please can this/the rest of the push be run on try before landing a third time :-)

Comment 5

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/aa978ffa44bc so it must have been :)

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

I backed this out along with all the other patches in the initial push. Something in the push regressed Ts on Android by 20% and I don't know which patch is to blame:

https://hg.mozilla.org/mozilla-central/rev/e94edfdb1f5b

Regression Ts increase 20.6% on Android 2.2 Mozilla-Inbound
--------------------------------------------------------------
    Previous: avg 2653.656 stddev 87.856 of 30 runs up to revision 1239bd0779a6
    New     : avg 3201.178 stddev 110.202 of 5 runs since revision 0d61a0d8dba4
    Change  : +547.522 (20.6% / z=6.232)
    Graph   : http://mzl.la/zD3EWy

Comment 7

[Mounir Lamouri (:mounir)]

https://hg.mozilla.org/mozilla-central/rev/7bcf75d570a8