720840 - GC: Call MarkStringUnbarriered directly

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Terrence Cole [:terrence]]

Attachment: v0

We have a special marker function for handling the Atom list because we need to call JS_SET_TRACING_INDEX externally to avoid clobbering the index.  However, nobody cares about the index here and if they do, they can add custom debug code.  It is better at this point to have a consistent and correct interface, thus we remove the specialized atomized string marking in favor of the existing string marker.

Comment 1

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Comment on attachment 591268 [details] [diff] [review]
v0

Review of attachment 591268 [details] [diff] [review]:
-----------------------------------------------------------------

Good to see these go.

::: js/src/jsatom.cpp
@@ +388,3 @@
>      if (rt->gcKeepAtoms) {
>          for (AtomSet::Range r = state->atoms.all(); !r.empty(); r.popFront()) {
> +            MarkStringUnbarriered(trc, r.front().asPtr(), "locked_atom");

I think you can use MarkRoot here.

@@ +394,5 @@
>              AtomStateEntry entry = r.front();
>              if (!entry.isTagged())
>                  continue;
>  
> +            MarkStringUnbarriered(trc, entry.asPtr(), "interned_atom");

and here.

Comment 2

[Terrence Cole [:terrence]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/680991750088

Comment 3

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/680991750088