721001 - [Mac] password entry fields not identified as such, entering password does not generate typical audible click

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect, P1)

Description

[Marco Zehe (:MarcoZ)]

Password entry fields have the following problems:
1. Their role description is not properly identified.
2. When entering text, the typical password click that can be heard in Safari and elsewhere within Mac OS X is not being generated.

I'm marking this bug security sensitive for now because I do not know if this can be exploited to somehow gain access to a user-entered password.

Comment 1

[Daniel Veditz [:dveditz]]

I don't think this is a security bug that needs to be hidden. The lack of sound might fool a user into not knowing it's a password field? But if so they wouldn't be entering their password. The lack of sound means they're lost and don't know which fields are which, resorting to guessing? Yeah, that's a problem, but if it's causing that kind of confusion people will know that even if they can't see this bug.

Comment 2

[Marco Zehe (:MarcoZ)]

I was thinking more along the lines: Is there something in our APIs that might make password fields exploitable even if people enter something? But wasn't sure, so better to be cautious than sorry. :) Thanks for clarifying!

Comment 3

[Hubert Figuiere [:hub]]

in Safari, "Secure Text Fields" return an empty value. We'll do the same with that patch.

Comment 4

[Hubert Figuiere [:hub]]

Attachment: Intansiate the right class and set the proper subrole for password field. r=

Comment 5

[Marco Zehe (:MarcoZ)]

Comment on attachment 613848 [details] [diff] [review]
Intansiate the right class and set the proper subrole for password field. r=

I built with this patch locally, and can confirm that a) VoiceOver announces password fields as "Secure Edit text" and that b) it clicks when typing in a password into such a field. The text is then not reviewable, which is correct.

Comment 6

[Trevor Saunders (:tbsaunde)]

Comment on attachment 613848 [details] [diff] [review]
Intansiate the right class and set the proper subrole for password field. r=

>-    
>+
>+  // A password text field return an empty value

nit, returns

Comment 7

[Hubert Figuiere [:hub]]

Thanks. And I'll also fix the typo in the commit log. I'll land tomorrow morning.

Comment 8

[Hubert Figuiere [:hub]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6c468f97100d

Comment 9

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

https://hg.mozilla.org/mozilla-central/rev/6c468f97100d