Closed
Bug 721103
Opened 12 years ago
Closed 12 years ago
handle webapp manifests with a UTF8 BOM in the validator
Categories
(addons.mozilla.org Graveyard :: Add-on Validation, defect, P1)
Tracking
(Not tracked)
RESOLVED
FIXED
6.4.0
People
(Reporter: kumar, Assigned: basta)
References
Details
Attachments
(1 file)
|
388 bytes,
text/plain
|
Details |
Attached is a manifest encoded with a BOM (as is typical for Windows files). The BOM needs to be stripped out of the manifest before parsing. This is how the AMO does it: https://github.com/mozilla/zamboni/commit/d476408b6eb11a1888952a5a4c75822eb8ef0fba See also bug 711538
|
Reporter | |
Updated•12 years ago
|
Assignee: nobody → mattbasta
Priority: -- → P1
Target Milestone: --- → 6.4.0
|
|
Reporter | |
Updated•12 years ago
|
Summary: handle webapp manifests with a UTF8 BOM → handle webapp manifests with a UTF8 BOM in the validator
|
Assignee | |
Comment 2•12 years ago
|
||
Done https://github.com/mozilla/amo-validator/pull/116
|
|
Reporter | |
Comment 3•12 years ago
|
||
Merged https://github.com/mozilla/amo-validator/commit/7fb5281aae973de9a2f065375a139e33ec7032c2
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
|
|
Reporter | |
Comment 4•12 years ago
|
||
Pushed to AMO Pushed to AMO https://github.com/mozilla/zamboni/commit/3f4982aa6b48109f408ac83efe26a22ccd2902b5
|
||
Updated•8 years ago
|
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•