Closed
Bug 721156
Opened 12 years ago
Closed 12 years ago
aError.stack is undefined in the Error Console when exception is thrown in Scratchpad
Categories
(DevTools Graveyard :: Scratchpad, defect)
DevTools Graveyard
Scratchpad
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 14
People
(Reporter: jaws, Assigned: harth)
Details
Attachments
(1 file)
928 bytes,
patch
|
rcampbell
:
review+
|
Details | Diff | Splinter Review |
STR:
In the browser context, run the following code:
> var eTLDService = Cc["@mozilla.org/network/effective-tld-service;1"].getService(Ci.nsIEffectiveTLDService);
> let baseDomain = eTLDService.getBaseDomain("www.msu.edu");
Actual results:
In the error console...
Timestamp: 1/25/2012 11:38:44 AM
Error: aError.stack is undefined
Source File: chrome://browser/content/scratchpad.js
Line: 470
Expected results:
An error within the Scratchpad stating that getBaseDomain expected a URI, not a string.
Assignee | ||
Comment 1•12 years ago
|
||
I run into this often, this patch fixes it. Sometimes Error.stack is undefined and we should show Error.fileName and Error.lineNumber in those cases.
Assignee: nobody → fayearthur
Attachment #608682 -
Flags: review?
Reporter | ||
Comment 2•12 years ago
|
||
\o/ Did you forget to assign the review to somebody?
Status: NEW → ASSIGNED
Reporter | ||
Updated•12 years ago
|
Attachment #608682 -
Flags: review? → review?(dcamp)
Assignee | ||
Comment 3•12 years ago
|
||
Comment on attachment 608682 [details] [diff] [review] Print file and line number if Error.stack isn't defined. My bad, meant to flag robcee.
Attachment #608682 -
Flags: review?(dcamp) → review?(rcampbell)
Comment 4•12 years ago
|
||
Comment on attachment 608682 [details] [diff] [review] Print file and line number if Error.stack isn't defined. yup yup.
Attachment #608682 -
Flags: review?(rcampbell) → review+
Assignee | ||
Comment 5•12 years ago
|
||
http://hg.mozilla.org/integration/fx-team/rev/5e087503286f
Whiteboard: [fixed-in-fx-team]
Comment 6•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/5e087503286f
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 14
Updated•6 years ago
|
Product: Firefox → DevTools
Updated•4 years ago
|
Product: DevTools → DevTools Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•