721164 - Return focus to Fennec on cancelled AccountActivity attempt

Status: RESOLVED INVALID

(Firefox for Android Graveyard :: Android Sync, defect, P3)

Description

[Aaron Train [:aaronmt]]

STR:

1. Launch Fennec
2. Tap 'Set up Firefox Sync' banner
3. Tap, 'I don't have a device with me' (org.mozilla.gecko.sync.setup.activities.AccountActivity)
4. Tap 'Cancel'

ER: Back to Fennec
AR: Back to Android application launcher

I/ActivityManager(  197): moveTaskToBack: 45
I/WindowManager(  197): createSurface Window{41c59678 com.android.launcher/com.android.launcher2.Launcher paused=false}: DRAW NOW PENDING

--
Samsung Galaxy Nexus (Android 4.0.3)
20120125040231
http://hg.mozilla.org/integration/mozilla-inbound/rev/badb5fd30031

Comment 1

[Richard Newman [:rnewman]]

Chenxia, please triage this. If we aren't doing anything funny with the view stack, please throw this into the Fennec Native > General component. If we are, then we can fix it :D

Comment 2

[Chenxia Liu [:liuche]]

After a reflow suggested in UI review, the "Cancel" button in manual Account Setup now returns to the J-PAKE display screen.

The Android Sync view stack is pretty ordinary, and leaving the app follows the default Android activity flow.

Comment 3

[Richard Newman [:rnewman]]

Chenxia doesn't think this is on our end (Comment 2). The cancel button just does this:

  public void cancelClickHandler(View target) {
    finish();
  }

(which is how you're supposed to exit an Activity), and the manual setup click handler — which launches AccountActivity — just does this:

  public void manualClickHandler(View target) {
    Intent accountIntent = new Intent(this, AccountActivity.class);
    accountIntent.setFlags(Intent.FLAG_ACTIVITY_NO_ANIMATION);
    startActivity(accountIntent);
    overridePendingTransition(0, 0);
  }

but I also don't see anything particularly suspicious in Fennec's code:

            intent = new Intent(mContext, SetupSyncActivity.class);
        mContext.startActivity(intent);

Ignoring this in favor of more important stuff until more information comes to light.

Comment 4

[Andreea Pod]

Also, if you go to Accounts & Sync > Firefox Sync  and right after that tap on system menu button, you will see "Cancel sync" (however, I think there should be "Sync now", please correct me if I'm wrong). If you tap on the "Cancel sync" button then again hit system menu button you will see again "Cancel sync" so that means sync was not canceled before. Is this problem related to the one described in this bug or should I file another bug for this?

Build: Firefox 14.0a1 (2012-04-08)
Device: LG Optimus 2X (Android 2.2)

Comment 5

[Aaron Train [:aaronmt]]

(In reply to Andreea Pod from comment #4)
>...

Correct me if I'm wrong, but there is more than likely a current Sync taking place or its the period of wait-time in-between Sync's where you can't force a Sync until the window opens again.

Comment 6

[Richard Newman [:rnewman]]

(In reply to Andreea Pod from comment #4)
> Also, if you go to Accounts & Sync > Firefox Sync  and right after that tap
> on system menu button, you will see "Cancel sync" (however, I think there
> should be "Sync now", please correct me if I'm wrong). If you tap on the
> "Cancel sync" button then again hit system menu button you will see again
> "Cancel sync" so that means sync was not canceled before. Is this problem
> related to the one described in this bug or should I file another bug for
> this?

It'll show "Cancel Sync" until Android believes that the sync is done.

We pretty much ignore that interrupt, so don't worry about this.

Comment 7

[Chenxia Liu [:liuche]]

We return to the J-PAKE setup screen, and have for a while now. UI decided that "cancel" should have the same effect as "back".