Closed
Bug 721205
Opened 12 years ago
Closed 12 years ago
GLContext::fReadPixels uses format GL_BGRA on Android, causing GL_INVALID_OPERATION
Categories
(Core :: Graphics: CanvasWebGL, defect)
Tracking
()
RESOLVED
FIXED
mozilla12
People
(Reporter: ajuma, Assigned: jgilbert)
References
Details
Attachments
(1 file)
2.91 KB,
patch
|
bjacob
:
review+
|
Details | Diff | Splinter Review |
With Attachment 591529 [details] [diff], Bug 720467 applied, the WebGL demo at http://spidergl.org/example.php?id=1 on XUL Fennec on a Nexus S causes GLContext::fReadPixels to be called with format GL_BGRA and type GL_UNSIGNED_BYTE, resulting in GL_INVALID_OPERATION. Since that patch doesn't change the logic used to choose the format for fReadPixels, we have a bug somewhere else.
Assignee | ||
Comment 1•12 years ago
|
||
According to specs for ES extensions: EXT_bgra explicitly adds support for GL_BGRA+GL_UNSIGNED_BYTE readPixels. EXT_read_format_bgra and IMG_read_format allow for the auxiliary format discovery for BGRA+UBYTE via GL_IMPLEMENTATION_COLOR_READ_FORMAT/TYPE.
Assignee: nobody → jgilbert
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•12 years ago
|
||
Attachment #591633 -
Flags: review?(bjacob)
Updated•12 years ago
|
Attachment #591633 -
Flags: review?(bjacob) → review+
Assignee | ||
Comment 3•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/fccccb47213e
Target Milestone: --- → mozilla12
Reporter | ||
Comment 4•12 years ago
|
||
With this patch applied, I'm still seeing the same problem. GL_IMPLEMENTATION_COLOR_READ_FORMAT and TYPE are BGRA and UNSIGNED_BYTE on this device, so it still tries to use GL_BGRA and causes a GL_INVALID_OPERATION error. So we seem to be running into a driver bug.
Comment 5•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/fccccb47213e
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•12 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•