Closed Bug 721350 Opened 12 years ago Closed 12 years ago

Style Editor auto-scroll to the selected style sheet is annoying

Categories

(DevTools :: Style Editor, defect)

Product:
DevTools
Component:
Style Editor
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox11 verified)

Status:
RESOLVED FIXED
Milestone:
Firefox 12
Tracking Flags:
Tracking Status
firefox11 --- verified

People

(Reporter: cedricv, Assigned: cedricv)

Details

(Whiteboard: [styleeditor][qa+][qa!:11])

Attachments

(2 files)

patch v1
1.03 KB, patch
paul
: review+
akeybl
: approval-mozilla-aurora+
Details | Diff | Splinter Review
Patch v1 - rebased for Aurora
961 bytes, patch
Details | Diff | Splinter Review 
The Style Editor should not scroll the list when the style sheet is selected because of a direct user click.
Whiteboard: [styleeditor] → [addToFirefox11][styleeditor]
Attached patch patch v1 — — Splinter Review 
It shouldn't be too hard to review.
Attachment #591758 - Flags: review?(paul)
Attachment #591758 - Flags: review?(paul) → review+
Whiteboard: [addToFirefox11][styleeditor] → [addToFirefox11][styleeditor][land-in-fx-team]
https://hg.mozilla.org/integration/fx-team/rev/d5ceec63ef0a
Whiteboard: [addToFirefox11][styleeditor][land-in-fx-team] → [addToFirefox11][styleeditor][fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/d5ceec63ef0a
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Whiteboard: [addToFirefox11][styleeditor][fixed-in-fx-team] → [addToFirefox11][styleeditor]
Target Milestone: --- → Firefox 12
Comment on attachment 591758 [details] [diff] [review]
patch v1

[Approval Request Comment]
Regression caused by (bug #): Not a regression, new feature.
User impact if declined: Bad user experience.
Testing completed (on m-c, etc.): on m-c.
Risk to taking this patch (and alternatives if risky): very very low. One JS line removed.
Attachment #591758 - Flags: approval-mozilla-aurora?
Comment on attachment 591758 [details] [diff] [review]
patch v1

[Triage Comment]
Low risk fix in support of a new feature. Approved for Aurora.
Attachment #591758 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
https://hg.mozilla.org/releases/mozilla-aurora/rev/5bc8243d71ec
status-firefox11: --- → fixed
Whiteboard: [addToFirefox11][styleeditor] → [styleeditor]
Whiteboard: [styleeditor] → [styleeditor][qa+]
Verified using Firefox 11 beta 3 on Windows 7, Ubuntu 11.10 and Mac OS X 10.6.

Mozilla/5.0 (Windows NT 6.1; rv:11.0) Gecko/20100101 Firefox/11.0
Mozilla/5.0 (X11; Linux i686; rv:11.0) Gecko/20100101 Firefox/11.0
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:11.0) Gecko/20100101 Firefox/11.0

The Style Editor does not scroll the list when the style sheet is selected by direct user click.
status-firefox11: fixed → verified
Whiteboard: [styleeditor][qa+] → [styleeditor][qa+][qa!:11]
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: