721502 - HttpChannelParent.cpp:336:0: warning: ignoring #pragma warning [-Wunknown-pragmas]

Status: RESOLVED FIXED

(Core :: Networking, defect)

Description

[Daniel Holbert [:dholbert]]

Filing bug on this warning:
HttpChannelParent.cpp:336:0: warning: ignoring #pragma warning  [-Wunknown-pragmas]

for this MSVC-specific line:
> 336 #pragma warning(disable : 4068)
http://mxr.mozilla.org/mozilla-central/source/netwerk/protocol/http/HttpChannelParent.cpp#336

The correct way to do this is demonstrated e.g. here in jsopcode.h:
> 286 #ifdef _MSC_VER
> 287 #pragma warning(push)
> 288 #pragma warning(disable:4100)
> 289 #endif
[...code that needs the warning disabled...]
> 436 #ifdef _MSC_VER
> 437 #pragma warning(pop)
> 438 #endif
http://mxr.mozilla.org/mozilla-central/source/js/src/jsopcode.h#288

That way, non-MSVC compilers don't see the pragma and won't complain about it.

Comment 1

[Atul Aggarwal]

This bug has been fixed as a part of bug 621446. Patch file being
https://bug621446.bugzilla.mozilla.org/attachment.cgi?id=605532