Closed
Bug 721557
Opened 12 years ago
Closed 12 years ago
GC: Make marking interfaces indirect
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
People
(Reporter: terrence, Unassigned)
References
Details
Attachments
(1 file)
|
15.00 KB,
patch
|
Details | Diff | Splinter Review |
Since we will need to update pointers through this interface, we need to unmark them as const. Some users of these will continue be const (e.g. incremental barriers and non-nursery-objects), however, I don't think it is worth the extra effort to double up the interface to preserve constness for these callers.
|
Reporter | |
Comment 1•12 years ago
|
||
It turns out this is a fairly accurate map of the places where trivial Nursery collection is going to be problematic. Most of the things we end up needing to explicitly deconstify are hash keys for the debugger and weakmap. I'm not sure where to go with this. Thoughts?
Attachment #591996 -
Flags: feedback?(wmccloskey)
|
|
Reporter | |
Comment 2•12 years ago
|
||
It looks as if there are not any terribly useful steps in-between the interface cleanup and the full rewriting indirection.
Summary: GC: deconstify marking interfaces → GC: Make marking interfaces indirect
Version: Trunk → Other Branch
|
|
Reporter | |
Updated•12 years ago
|
Attachment #591996 -
Flags: feedback?(wmccloskey)
|
|
Reporter | |
Comment 3•12 years ago
|
||
I think everything here has landed in other bugs now.
Assignee: terrence → general
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla13
Version: Other Branch → 15 Branch
|
|
Reporter | |
Updated•12 years ago
|
Target Milestone: mozilla13 → ---
Version: 15 Branch → Trunk
You need to log in
before you can comment on or make changes to this bug.
Description
•