721579 - Remove rt->gcTriggerBytes and rt->gcLastBytes

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Attachment: patch

These fields are now used in only one place: a weird case in TriggerCompartmentGC that I've never seen get used. I added the code a long time ago when I was worried that we might get into a situation where full GCs were never happening. I don't think we have to worry about that, though :-(.

Comment 1

[Igor Bukanov]

Comment on attachment 591991 [details] [diff] [review]
patch

Review of attachment 591991 [details] [diff] [review]:
-----------------------------------------------------------------

Reducing unnecessary complexity of our GC heuristics is really nice!

Comment 2

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1ed8ccf96402

Comment 3

[Phil Ringnalda (:philor)]

Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/71f5bf4df2f6 - one of the six in that push was crashing in js::gc::Mark<JSString>

Comment 4

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/70dd3b785599

Comment 5

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/70dd3b785599