72177 - email filtering consistency

Status: RESOLVED FIXED

(Bugzilla :: Email Notifications, defect, P3)

Description

[Stephan Niemz]

As much as I appreciate the new email filtering options, I think they should
be consistent to avoid confusion, i.e. a checked box should always mean the
same, e.g. "send me mail" or "don't send me mail".

The first option is labeled "Do not email me bugs that I change" (negative)
while all the other ones are labeled "email me when ..." (positive).  So I
suggest reversing the first checkbox to read "Email me bugs that I change".

This way I could see by a quick glance whether I have any filtering options
active (anything not checked) or not.

Comment 1

[Dave Miller [:justdave]]

Nominating for 2.12.  We've got enough other crap to fix with the email system 
before 2.12 can go out anyway, this will be an easy one to sneak in, and I agree, 
the current preference is backwards.

Comment 2

[Stephen Lee]

Changing this to a positive could make it ambiguous IMO.

e.g. If you have
 "Email me bugs that I change" checked and "Keywords field changes" unchecked, 
and then you make a change only to the keywords field.

One option says you should have email, because it is a bug that you changed, 
but actually you wouldn't because none of your field-specific options triggered 
an email.

ISTM that the option is by nature 'negative' as it is disabling email that you 
would otherwise get, whereas all the other options enable email that you 
otherwise wouldn't get.

The option currently missing beside it "Do not email me any bugs" or "Disable 
all bug email" (Would be useful for vacations etc - Bug 66839) would also IMO 
seem more logical expressed in the negative.

Comment 3

[Tara Hernandez]

I'm with Stephen on all counts.  Global negatives make more sense to me.  If we
were cool individuals, we could do something where we had "no mail" and "all
mail" (whatever verbage you like) buttons that would do the right things to all
the checkboxes to make it even more obvious.

Comment 4

[Dave Miller [:justdave]]

Yeah, Stephen's right.  After I got to looking at it, I couldn't come up with a 
way to describe what that checkbox did in a positive way and still be accurate 
without involving a whole paragraph of text, and it wouldn't look real good at 
that point.

Should we just clarify the negative text to make it a little more clear?  Or 
leave it how it is?

Comment 5

[Gervase Markham [:gerv]]

How about "Only email me reports of changes made by other people"? This does not 
reverse the meaning of the checkbox, yet could be considered clearer.

Gerv

Comment 6

[Chris Yeh]

Moving to 2.16, move back to 2.12 if you come up with effective wording.

Comment 7

[Christopher Aillon (sabbatical, not receiving bugmail)]

Mass moving to new product Bugzilla...

Comment 8

[Jacob Steenhagen]

*** Bug 97846 has been marked as a duplicate of this bug. ***

Comment 9

[Gervase Markham [:gerv]]

Attachment: Patch v.1

Comment 10

[Gervase Markham [:gerv]]

Here's a patch with my wording. Looking for a= from Dave.

Gerv

Comment 11

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 53530 [details] [diff] [review]
Patch v.1

r=myk

Comment 12

[Dave Miller [:justdave]]

Comment on attachment 53530 [details] [diff] [review]
Patch v.1

r= justdave

Comment 13

[Gervase Markham [:gerv]]

/cvsroot/mozilla/webtools/bugzilla/userprefs.cgi,v  <--  userprefs.cgi
new revision: 1.23; previous revision: 1.22

Gerv