Closed
Bug 721855
Opened 12 years ago
Closed 12 years ago
Honour gfx.canvas.azure.prefer-skia pref on OS X
Categories
(Core :: Graphics, defect)
Tracking
()
RESOLVED
FIXED
mozilla12
People
(Reporter: gw280, Assigned: gw280)
Details
Attachments
(1 file, 3 obsolete files)
4.64 KB,
patch
|
Details | Diff | Splinter Review |
We should honour that pref on OS X. Currently it's hard coded to use CG.
Assignee | ||
Comment 1•12 years ago
|
||
Attachment #592239 -
Flags: review?(jmuizelaar)
Assignee | ||
Updated•12 years ago
|
Attachment #592239 -
Attachment is patch: true
Comment 2•12 years ago
|
||
Comment on attachment 592239 [details] [diff] [review] Use pref on os x Use GetBoolVarCache?
Attachment #592239 -
Flags: review?(jmuizelaar) → review-
Comment 3•12 years ago
|
||
AddBoolVarCache
Assignee | ||
Comment 4•12 years ago
|
||
Attachment #592239 -
Attachment is obsolete: true
Attachment #592251 -
Flags: review?(jmuizelaar)
Comment 5•12 years ago
|
||
Comment on attachment 592251 [details] [diff] [review] updated patch This would be better off in gfxPlatform and can be initialized in gfxPlatform's constructor.
Attachment #592251 -
Flags: review?(jmuizelaar) → review-
Assignee | ||
Comment 6•12 years ago
|
||
Attachment #592251 -
Attachment is obsolete: true
Attachment #592264 -
Flags: review?(jmuizelaar)
Assignee | ||
Updated•12 years ago
|
Attachment #592264 -
Flags: review?(joe)
Updated•12 years ago
|
Attachment #592264 -
Flags: review?(jmuizelaar) → review+
Comment 7•12 years ago
|
||
Comment on attachment 592264 [details] [diff] [review] refactor the wooooorld Review of attachment 592264 [details] [diff] [review]: ----------------------------------------------------------------- ::: gfx/thebes/gfxD2DSurface.cpp @@ +127,5 @@ > const gfxIntSize gfxD2DSurface::GetSize() const > { > return gfxIntSize(cairo_d2d_surface_get_width(mSurface), > cairo_d2d_surface_get_height(mSurface)); > +} THIS IS NOT PERMITTED IN THIS PATCH ::: gfx/thebes/gfxPlatform.h @@ +449,5 @@ > > // which scripts should be shaped with harfbuzz > PRInt32 mUseHarfBuzzScripts; > > + // The preferred azure backend to use _DRAW TARGET_ backend ::: gfx/thebes/gfxWindowsPlatform.cpp @@ +559,3 @@ > } > + > + return true; Put the return with the aBackend assignment, and return false outside the if.
Attachment #592264 -
Flags: review?(joe)
Attachment #592264 -
Flags: review?(jmuizelaar)
Attachment #592264 -
Flags: review+
Assignee | ||
Comment 8•12 years ago
|
||
Pushed to try at https://tbpl.mozilla.org/?tree=Try&rev=28888d108556
Attachment #592264 -
Attachment is obsolete: true
Attachment #592264 -
Flags: review?(jmuizelaar)
Assignee | ||
Comment 9•12 years ago
|
||
Looks like this can be checked in. The TBPL shows that the only test failures are either known intermittent failures, or are already/also present on other completely unrelated tests that have also been pushed to try.
Keywords: checkin-needed
Updated•12 years ago
|
Assignee: nobody → gwright
Comment 10•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/68b7ab93105f
Keywords: checkin-needed
Target Milestone: --- → mozilla12
Comment 11•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/68b7ab93105f
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•