722046 - remove extra semicolon after NS_DECl_EVENT_HANDLER

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Landry Breuil (:gaston)]

Followup to bug #718132, (and similar to #704729) m-c fails now on OpenBSD/gcc 4.2.1 with a bunch of :
In file included from ../../dist/include/mozilla/dom/indexedDB/IndexedDatabaseManager.h:45,
                 from ../../dist/include/mozilla/dom/indexedDB/FileInfo.h:46,
                 from ../../dist/include/nsDOMFile.h:56,
                 from /home/landry/src/mozilla-central/layout/forms/../../content/html/content/src/nsHTMLInputElement.h:51,
                 from /home/landry/src/mozilla-central/layout/forms/nsFileControlFrame.cpp:67:
../../dist/include/mozilla/dom/indexedDB/IDBDatabase.h:158: error: extra ';'
../../dist/include/mozilla/dom/indexedDB/IDBDatabase.h:159: error: extra ';'
../../dist/include/mozilla/dom/indexedDB/IDBDatabase.h:160: error: extra ';'
In file included from ../../dist/include/mozilla/dom/indexedDB/IndexedDatabaseManager.h:46,
                 from ../../dist/include/mozilla/dom/indexedDB/FileInfo.h:46,
                 from ../../dist/include/nsDOMFile.h:56,
                 from /home/landry/src/mozilla-central/layout/forms/../../content/html/content/src/nsHTMLInputElement.h:51,
                 from /home/landry/src/mozilla-central/layout/forms/nsFileControlFrame.cpp:67:
../../dist/include/mozilla/dom/indexedDB/IDBRequest.h:161: error: extra ';'
../../dist/include/mozilla/dom/indexedDB/IDBRequest.h:162: error: extra ';'

Patch incoming..

Comment 1

[Landry Breuil (:gaston)]

Attachment: Remove extra semicolons

Comment 2

[Landry Breuil (:gaston)]

And it seems it's very similar to bug #720815 which resolution only fixed one of three occurences..

Comment 3

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 592396 [details] [diff] [review]
Remove extra semicolons

r=me if you also fix the others at <http://mxr.mozilla.org/mozilla-central/ident?i=NS_DECL_EVENT_HANDLER>

Comment 4

[Landry Breuil (:gaston)]

Attachment: Remove extra semicolons

Sure, here you are. Wonder why IDBTransaction.h didn't error out first (i can understand for dom/telephony)

Comment 5

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 592401 [details] [diff] [review]
Remove extra semicolons

Thanks. (Don't forget to update your commit message.)

Comment 6

[Landry Breuil (:gaston)]

I can't edit the commit message without reposting a new patch & reasking for review, and i didn't hit the other occurences.. so, to whoever commits the diff, please remove the extra error lines and only keep the summary line. (is it the right way to do it ?)

Comment 7

[Daniel Holbert [:dholbert]]

Pushed:
 https://hg.mozilla.org/integration/mozilla-inbound/rev/d9a514effc2a

Also, for future reference:

(In reply to Landry Breuil from comment #6)
> I can't edit the commit message without reposting a new patch & reasking for
> review

Don't worry about reasking for review in that case -- if someone grants you r+ with a few changes requested, general practice is to re-post without needing to ask for review on the new patch.  (Just be sure not to obsolete the old patch, so that whoever pushes the patch will see that an earlier version has gotten r+ & can easily compare the two versions)

(No need to do that here, though, as I've already pushed the patch w/ updated commit message)

> please remove the extra error lines and only keep the summary line.
> (is it the right way to do it ?)

Yup -- single-line commit messages are the standard practice for mozilla repositories.
(like "Bug XXX: change foo to bar. r=whoever")

Comment 8

[Daniel Holbert [:dholbert]]

(adding "buildwarning" keyword since this caused build warnings on Linux GCC 4.6)

Comment 9

[Daniel Holbert [:dholbert]]

(er s/keyword/bug-dependency/. Finished with bugspam now, sorry. :))

Comment 10

[Joe Drew (not getting mail)]

https://hg.mozilla.org/mozilla-central/rev/d9a514effc2a