722202 - Stop doing a recursive chmod on directories every time we upload to a candidates dir

Status: RESOLVED FIXED

(Release Engineering :: Release Automation: Other, defect, P2)

Description

[Nick Thomas [:nthomas] (UTC+12)]

Bug 484972 added a recursive chmod on dirs, to make sure the permissions were set safely on all candidate sub-directories. But didn't think about performance at all in the face of a busy netapp. Now you upload a log (while a virus scan is running amongst multiple other things), and the post_upload bogs down doing chmod that it needn't.

Comment 1

[Nick Thomas [:nthomas] (UTC+12)]

Lets get this done asap to try to dig stage out of it's hole.

Comment 2

[Nick Thomas [:nthomas] (UTC+12)]

Attachment: [tools] Disable chmod for release to candidates

As far as we can tell this code isn't necessary, because dirs are created 755 and files set to 644, but we will find out when we do the next release when check_permissions runs.

Comment 3

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 595621 [details] [diff] [review]
[tools] Disable chmod for release to candidates

http://hg.mozilla.org/build/tools/rev/4988e5cda458

Comment 4

[Nick Thomas [:nthomas] (UTC+12)]

Deployed to stage.m.o.

Comment 5

[Armen [:armenzg]]

I think we have a problem with this on bug 729998.
We don't know though why it would show up for beta4 rather than beta 2 & 3 as well.

Comment 7

[[e-mail] (:bhearsum)]

Mass move of bugs to Release Automation component.

Comment 8

[[e-mail] (:bhearsum)]

Looks like we still do this for mobile candidates directories: https://hg.mozilla.org/build/tools/file/default/stage/post_upload.py#l364

Comment 9

[Nick Thomas [:nthomas] (UTC+12)]

Attachment: [tools] Remove dirs chmod for mobile candidates too

Only 79 dirs in a mobile candidate dir vs 1500+ for desktop so not as big of a problem. Here's the patch for completeness anyway.

Comment 10

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 8547413 [details] [diff] [review]
[tools] Remove dirs chmod for mobile candidates too

Canonical copy:
https://hg.mozilla.org/build/tools/rev/42ba198e06d4

Deployed using IT puppet:
Committed revision 99145.