722412 - Cleanup nsPlaintextEditor::SetDocumentCharacterSet

Status: RESOLVED FIXED

(Core :: DOM: Editor, defect)

Description

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Patch v1

Comment 1

[(no longer active)]

Comment on attachment 592805 [details] [diff] [review]
Patch v1

Review of attachment 592805 [details] [diff] [review]:
-----------------------------------------------------------------

::: editor/libeditor/text/nsPlaintextEditor.cpp
@@ +238,5 @@
> +  // update META charset tag
> +  nsCOMPtr<nsIDOMDocument> domdoc;
> +  rv = GetDocument(getter_AddRefs(domdoc));
> +  NS_ENSURE_SUCCESS(rv, rv);
> +  NS_ENSURE_TRUE(domdoc, NS_OK);

NS_ERROR_FAILURE.

@@ +293,3 @@
>  
> +  PRUint32 listLength = 0;
> +  (void) metaList->GetLength(&listLength);

Drop the unneeded cast please.

::: editor/libeditor/text/nsPlaintextEditor.h
@@ +107,5 @@
>    NS_IMETHOD SetDocumentCharacterSet(const nsACString & characterSet);
>  
> +private:
> +  bool UpdateMetaCharset(nsIDOMDocument* aDocument,
> +                         const nsACString& aCharacterSet);

Nit: move this to the end of the public section please.

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/c346b375b471