722636 - "Undo Add to Dictionary" context menu is displayed outside of text fields

Status: VERIFIED FIXED

(Core :: Spelling checker, defect)

Description

[Matthew N. [:MattN]]

Attachment: v.1 Show (with separator) when "Check spelling" is shown (with tests)

The new "Undo Add to Dictionary" context menu entry is displayed independent of what the user right-clicked once there is an addition to undo.  This means that "Undo Add to Dictionary" appears as the *first* context menu item on images, links, documents, etc.  This gets annoying since the dictionary entry could have been hours ago and people are used to the order of the context menu items.

In my opinion, "Undo Add to Dictionary" should only appear when the "Check spelling" checkbox is displayed (in text fields).

Comment 1

[Matthew N. [:MattN]]

Nominated for tracking-firefox12:
Gaving the first context menu everywhere be "Undo Add to Dictionary" after adding a word to the dictionary has a significant usability impact.  ie. Users expect "Open link in New Tab" first in the menu on links.

Comment 2

[(no longer active)]

Comment on attachment 593014 [details] [diff] [review]
v.1 Show (with separator) when "Check spelling" is shown (with tests)

Looks very good, thanks!

Comment 3

[Asa Dotzler [:asa]]

Yeah. We should try to get this uplifted to where the regression happened or back out the change until it can land with this fix.

Comment 4

[Matthew N. [:MattN]]

I'm going to land it on m-c in the next day and then request approval for Aurora

Comment 5

[Matthew N. [:MattN]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/36b986ef4b5b

Try run: https://tbpl.mozilla.org/?tree=Try&rev=6db593b1780e

Comment 6

[Matthew N. [:MattN]]

Comment on attachment 593014 [details] [diff] [review]
v.1 Show (with separator) when "Check spelling" is shown (with tests)

[Approval Request Comment]
Regression caused by (bug #): 352037 
User impact if declined: Significant usability decrease if "Add to Dictionary" is used.  The new undo option will become the top centext menu item everywhere (ie. instead of "Open link in new tab" or "Back").
Testing completed (on m-c, etc.): m-c
Risk to taking this patch (and alternatives if risky): Low risk, undo option won't show up as much
String changes made by this patch: None

Comment 7

[Asa Dotzler [:asa]]

I support this change. It's simple and fixes a usability regression.

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/36b986ef4b5b

Comment 9

[Alex Keybl [:akeybl]]

Comment on attachment 593014 [details] [diff] [review]
v.1 Show (with separator) when "Check spelling" is shown (with tests)

[Triage Comment]
Given how early we are in Aurora 12, and the input from product, approved.

Comment 10

[(no longer active)]

http://hg.mozilla.org/releases/mozilla-aurora/rev/72ec179d6f8e

Comment 11

[Simona Badau, Desktop QA]

Verified using Firefox 12 beta 3 on Windows 7, Mac OS 10.6 and Ubuntu 11.10 that -"Undo Add to Dictionary" context menu is not displayed outside of text fields.

Mozilla/5.0 (Windows NT 6.1; rv:12.0) Gecko/20100101 Firefox/12.0
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:12.0) Gecko/20100101 Firefox/12.0
Mozilla/5.0 (X11; Linux i686; rv:12.0) Gecko/20100101 Firefox/12.0