Closed
Bug 722690
Opened 12 years ago
Closed 12 years ago
buttons are too close to edge
Categories
(Calendar :: Dialogs, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
1.5
People
(Reporter: andreasn, Assigned: Paenglab)
Details
Attachments
(2 files, 1 obsolete file)
|
46.90 KB,
image/png
|
Details | |
|
522 bytes,
patch
|
andreasn
:
review+
andreasn
:
ui-review+
|
Details | Diff | Splinter Review |
spacing - current and proposed
The spacing in the New event dialog is slightly off. The first button is too close to the left edge and all of the buttons are too close to the bottom edge. Especially compared to the calendar toolbar.
|
Assignee | |
Comment 1•12 years ago
|
||
The Tabs-on-top patch introduced for the .chromeclass-toolbar a negative margin. This patch fixes this.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #593917 -
Flags: ui-review?(nisses.mail)
Attachment #593917 -
Flags: review?(nisses.mail)
|
Reporter | |
Comment 2•12 years ago
|
||
Comment on attachment 593917 [details]
Fix the negative margin
I think it needs some padding-bottom of 2px added as well.
ui-r and r plus with that fixed.
Attachment #593917 -
Flags: ui-review?(nisses.mail)
Attachment #593917 -
Flags: ui-review-
Attachment #593917 -
Flags: review?(nisses.mail)
Attachment #593917 -
Flags: review-
|
|
Assignee | |
Comment 3•12 years ago
|
||
I gave now on top a padding of 1px and on bottom 2px.
Attachment #593917 -
Attachment is obsolete: true
Attachment #593954 -
Flags: ui-review?(nisses.mail)
Attachment #593954 -
Flags: review?(nisses.mail)
|
|
Reporter | |
Comment 4•12 years ago
|
||
Comment on attachment 593954 [details] [diff] [review] Fix the negative margin v2 Works great!
Attachment #593954 -
Flags: ui-review?(nisses.mail)
Attachment #593954 -
Flags: ui-review+
Attachment #593954 -
Flags: review?(nisses.mail)
Attachment #593954 -
Flags: review+
|
|
Assignee | |
Comment 5•12 years ago
|
||
Pushed to comm-central: <http://hg.mozilla.org/comm-central/rev/d950eae8189d>
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.5
|
|
Assignee | |
Comment 6•12 years ago
|
||
Comment on attachment 593954 [details] [diff] [review] Fix the negative margin v2 Because the negative margin was introduced by the tabs-on-top patch, this patch should also go to aurora and beta.
Attachment #593954 -
Flags: approval-calendar-beta?
Attachment #593954 -
Flags: approval-calendar-aurora?
|
||
Comment 7•12 years ago
|
||
Comment on attachment 593954 [details] [diff] [review] Fix the negative margin v2 Removing outdated approval flags. Since time of request the patch has matured to comm-beta already and will be released with Lightning 1.5 soon.
Attachment #593954 -
Flags: approval-calendar-beta?
Attachment #593954 -
Flags: approval-calendar-aurora?
You need to log in
before you can comment on or make changes to this bug.
Description
•