Closed Bug 722752 Opened 12 years ago Closed 12 years ago

Home page shows set up banner even though Sync was just set up

Categories

(Firefox for Android Graveyard :: General, defect)

Product:
Firefox for Android Graveyard
Component:
General
Platform:
ARM
All
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox11 fixed, firefox12 fixed, firefox13 fixed, fennec+)

Status:
VERIFIED FIXED
Milestone:
Firefox 13
Tracking Flags:
Tracking Status
firefox11 --- fixed
firefox12 --- fixed
firefox13 --- fixed
fennec + ---

People

(Reporter: tracy, Assigned: lucasr)

References

Details

Attachments

(1 file)

Show/hide sync banner when sync accounts are added/removed
4.16 KB, patch
mfinkle
: review+
akeybl
: approval-mozilla-aurora+
akeybl
: approval-mozilla-beta+
Details | Diff | Splinter Review 
After connection mobile device (in this Samsung 10.1 tab), Return to Aurora start page shows the set up sync banner across the top sites section of that page.  reloading the page makes the banner go away.

expected results:  the start page should not sow the setup banner once the device has been connected to an account.
Component: Android Sync → General
Product: Mozilla Services → Fennec Native
QA Contact: android-sync → general
Hey Tracy, this is bug 721354 which landed yesterday on Aurora. Can you try today's build?
Aaron, build is Mozilla/5.0 (Android; Linux armv7l; rv:11.0a2) Gecko/20120131 Firefox/11.0a2 Fennec/11.oa2  on Samsung Galaxy Tab 10.1

Doesn't appear both birds got got.
(In reply to Tracy Walker [:tracy] from comment #2)
> Aaron, build is Mozilla/5.0 (Android; Linux armv7l; rv:11.0a2)
> Gecko/20120131 Firefox/11.0a2 Fennec/11.oa2  on Samsung Galaxy Tab 10.1
> 
> Doesn't appear both birds got got.

Lucas?
Blocks: 721354
Attachment #593454 - Flags: review?(mark.finkle) → review+
Comment on attachment 593454 [details] [diff] [review]
Show/hide sync banner when sync accounts are added/removed

Important UX fix for about:home. Non-risky.
Attachment #593454 - Flags: approval-mozilla-beta?
Attachment #593454 - Flags: approval-mozilla-aurora?
tracking-fennec: --- → +
https://hg.mozilla.org/mozilla-central/rev/36fb43ea8f0c
Assignee: nobody → lucasr.at.mozilla
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 13
Comment on attachment 593454 [details] [diff] [review]
Show/hide sync banner when sync accounts are added/removed

[Triage Comment]
Mobile only - approved for Aurora 12 and Beta 11.
Attachment #593454 - Flags: approval-mozilla-beta?
Attachment #593454 - Flags: approval-mozilla-beta+
Attachment #593454 - Flags: approval-mozilla-aurora?
Attachment #593454 - Flags: approval-mozilla-aurora+
Verified fixed on:

Firefox 13.0a1 (2012-02-06)
20120206031148
http://hg.mozilla.org/mozilla-central/rev/814d0b2dbaba
Device: HTC Desire Z
OS: Android 2.3.3

Firefox 12.0a2 (2012-02-06)
20120206042011
http://hg.mozilla.org/releases/mozilla-aurora/rev/9fb0c06ceb49
Device: HTC Desire Z
OS: Android 2.3.3

Firefox 11.0
20120206042108
http://hg.mozilla.org/releases/mozilla-beta/rev/6a71fe8b7ada
Device: HTC Desire Z
OS: Android 2.3.3
Status: RESOLVED → VERIFIED
status-firefox11: affected → fixed
status-firefox12: affected → fixed
status-firefox13: --- → fixed
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: