Closed
Bug 722940
Opened 12 years ago
Closed 12 years ago
codesize upload broken for SeaMonkey [and Thunderbird] due to tools dir being incorrect
Categories
(Release Engineering :: General, defect)
Release Engineering
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: Callek, Assigned: Callek)
References
Details
Attachments
(1 file)
|
1.68 KB,
patch
|
bhearsum
:
review+
Callek
:
checked-in+
|
Details | Diff | Splinter Review |
After porting Bug 561198 for SeaMonkey buildbot, I notice that we're failing to upload codesize (pack_scp not found). Verifying the script is in the proper place in /tools I realize that its being called via a '../tools' which when a comm-central app is the project its based on, is the incorrect path. Solution is to make use of the WithProperties and toolsdir... This patch does just that, and does it in all these places, rather than relying on magic knowledge of specifically where we put the toolsdir.
Attachment #593270 -
Flags: review?(bhearsum)
|
||
Updated•12 years ago
|
Attachment #593270 -
Flags: review?(bhearsum) → review+
|
Assignee | |
Comment 1•12 years ago
|
||
Comment on attachment 593270 [details] [diff] [review] [buildbotcustom] v1 Thanks for the fast review! http://hg.mozilla.org/build/buildbotcustom/rev/ad9e179c4a17 And pushed to seamonkey-production as a separate cset rather than doing a merge right now. http://hg.mozilla.org/build/buildbotcustom/rev/fa72a6c9d8b8
Attachment #593270 -
Flags: checked-in+
|
|
Assignee | |
Updated•12 years ago
|
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
|
||
Updated•11 years ago
|
Product: mozilla.org → Release Engineering
You need to log in
before you can comment on or make changes to this bug.
Description
•