72298 - SpecialFolder icon problems with folderPane.css

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect, P3)

Description

[(not reading, please use [e-mail] instead)]

andrew, I noticed a bunch of problems with folderPane.css in the classic skin.

examples:  there are no rules in folderPane.css for templates folder and the sent.

looking at hewitt's folderPane.css (for modern) perhaps we can follow that.

Comment 1

[hangas]

Themes Triage Team Marking nsbeta1+

Comment 2

[andreww]

Attachment: changes to mac folderpane.css

Comment 3

[andreww]

got mac, now windows.

Comment 4

[andreww]

Attachment: folderpane.css changes to windows classic

Comment 5

[Joe Hewitt (gone)]

sr=hewitt

Comment 6

[Andrew Thompson]

r=lordpixel

I see new drafts, sent and templates icons after applying this

Comment 7

[andreww]

fix checked in.

Comment 8

[esther]

Using build 2001-05-25 on win, mac and linux I see Special Folder icons for 
Drafts, Templates, Sent and Trash in Classic.  They are different icons than 
Modern, is there a link to the spec where I can see the icons so I can confirm 
they are the right icons?

Comment 9

[[e-mail] (gone - use [e-mail] instead)]

The only spec I saw on http://www.mozilla.org/mailnews/specs was for Modern, but
Jennifer might be able to just view Classic and verify that they look alright.

Comment 10

[jglick]

So 72816 would be a dup of this bug?

Comparing classic skin to 4.x, Inbox, Drafts, Templates, Sent and Trash appear 
to be using the correct icons. "Unsent Messages" is still using a generic folder 
though instead of the 4.x icon.

Comment 11

[Håkan Waara]

Jglick, yes, that bug is a duplicate of this.

I (virtually) have a fix in hand. Will attach it soon.

Comment 12

[Håkan Waara]

Taking

Comment 13

[Håkan Waara]

keep andreww as cc

Comment 14

[andreww]

thanks :)

Make sure you love mac classic as much as windows classic.

Comment 15

[Håkan Waara]

Rebuilding and testing a possible fix for this right now...

Comment 16

[Håkan Waara]

*** Bug 72816 has been marked as a duplicate of this bug. ***

Comment 17

[Håkan Waara]

Attachment: fix

Comment 18

[Håkan Waara]

Fixed and tested on all themes. The problem was that the CSS for it simply
wasn't written.

andreww, hewitt - wanna review this?

Comment 19

[Peter Lairo]

on build 2001-05-30 (modern theme) there are stil several special folders that
still use the default folder icon:
- IMAP "Sent Items" 
- POP "nstmp" 
- Local Folders "unsent messages" 

Will this be fixed for BOTH themes by you patch? If not this bug shouldn't be
closed, or we need a new bug.

Comment 20

[Peter Lairo]

The above is true for the classic theme as well:
On build 2001-05-30 (CLASSIC theme) there are stil several special folders that
still use the default folder icon:
- IMAP "Sent Items" 
- POP "nstmp" ([e-mail] -> comuserve)
- Local Folders "unsent messages" 

BTW, I filed bug 83459 for this in the modern theme.

Comment 21

[Håkan Waara]

yes, both skins.

Comment 22

[andreww]

r = andreww for hwaara's patch.

Comment 23

[Joe Hewitt (gone)]

sr=hewitt

Comment 24

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

a=dbaron for trunk checkin

Comment 25

[Håkan Waara]

fix checked in.

Comment 26

[Håkan Waara]

Verified fixed in the win nightly from today.

Comment 27

[esther]

We no longer have a Sent Items folder (I only saw it with AOL accounts originally)
It's now called Sent Mail and is not a special folder.
POP "nstmp" is a bug, this should not have been created, so it's not a special
folder
All other special foldder icons are displaying on Win, mac and linux in both
Classic and Modern
Verified