723048 - CSS Class names for scopes shouldn't have spaces

Status: RESOLVED FIXED

(DevTools :: Debugger, defect, P3)

Description

[Panos Astithas (he/him) [:past] (please ni?)]

In debugger-view.js we currently use the scope name as its class name, leading to classes like "Local-scope" and "With block-scope". It would be nice to use more regular class names for scopes.

Comment 1

[Victor Porof [:vporof][:vp]]

I'll take this.

Comment 2

[Victor Porof [:vporof][:vp]]

Attachment: v1

Also fixed typos in DVP__addProperty documentation.

Comment 3

[Panos Astithas (he/him) [:past] (please ni?)]

Comment on attachment 599593 [details] [diff] [review]
v1

Review of attachment 599593 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good.

Comment 4

[Panos Astithas (he/him) [:past] (please ni?)]

Although I have to admit it bothers me that we are still using a localizable string as a class name, I hope that this won't create more problems in the future.

Comment 5

[Victor Porof [:vporof][:vp]]

(In reply to Panos Astithas [:past] from comment #4)
> Although I have to admit it bothers me that we are still using a localizable
> string as a class name, I hope that this won't create more problems in the
> future.

I can easily change this. However, we're not using it as a class name (it's just "scope"). We're using it as an id, and I don't think we're (or will be) querying it anywhere (because every scope is cached in DebuggerView.Properties).

Comment 6

[Panos Astithas (he/him) [:past] (please ni?)]

(In reply to Victor Porof from comment #5)
> (In reply to Panos Astithas [:past] from comment #4)
> > Although I have to admit it bothers me that we are still using a localizable
> > string as a class name, I hope that this won't create more problems in the
> > future.
> 
> I can easily change this. However, we're not using it as a class name (it's
> just "scope"). We're using it as an id, and I don't think we're (or will be)
> querying it anywhere (because every scope is cached in
> DebuggerView.Properties).

I was mainly concerned with producing CSS errors in the console, but after reading the spec, I think it's fine:

http://www.w3.org/TR/CSS21/syndata.html#value-def-identifier

Comment 7

[Rob Campbell [:rc] (:robcee)]

https://hg.mozilla.org/integration/fx-team/rev/e1098816a74f

Comment 8

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/e1098816a74f