723138 - Language packs should work for all releases of a branch, maxVersion should use * for compatibility ranges

Status: RESOLVED FIXED

(MailNews Core :: Build Config, enhancement)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

The language packs provided in the release folder on the ftp should work for all releases of a branch and not only a single release. With Enterprise Support Releases (ESR), this should provide more benefits (but also for normal users). At the moment, the language pack have the same minVersion and maxVersion, but because the strings are frozen, compatibility ranges should look like 10.0 - 10.0.* (This is being done for Thunderbird 3.1.x)

Comment 1

[Mark Banner (:standard8)]

Ok, I'm moving this to core build config, as I suspect it affects everyone, although I also suspect we'll need different sets of fixes across the board.

Comment 2

[Mark Banner (:standard8)]

Ok, Commandeering this back to Mailnews for the c-c part of what I'm going to be posting in bug 723135.

Comment 3

[Mark Banner (:standard8)]

Attachment: The fix

This is the c-c version of the fix from bug 723135.

Comment 4

[Justin Wood (:Callek)]

Comment on attachment 601022 [details] [diff] [review]
The fix

I'm ok with this IFF the relevent m-c patch lands.

One caveat to note though is that chemspill releases will get a weird maxversion in the langpacks of, e.g. 11.0.1.* rather than 11.0.* with your code here

Comment 5

[Mark Banner (:standard8)]

Comment on attachment 601022 [details] [diff] [review]
The fix

Damn, I meant to account for that. Gonna have to rethink that a little.

Comment 6

[Mark Banner (:standard8)]

Attachment: The fix v2

Ok, this matches the patch in bug 723135. I'm hoping to land this on Monday, so that we've got it in time for the various releases.

Comment 8

[Mark Banner (:standard8)]

Checked in:

http://hg.mozilla.org/comm-central/rev/5c06bd39f172

Comment 9

[Mark Banner (:standard8)]

This also required a bustage fix as bug 723135 hasn't landed yet:

http://hg.mozilla.org/comm-central/rev/74679c8cb51d

Comment 10

[Mark Banner (:standard8)]

Comment on attachment 614777 [details] [diff] [review]
The fix v2

[Triage Comment]
Moving forward across releases, as I want the test pilot fix for TB 12, and the langpack fixes for ESR.

Comment 11

[Mark Banner (:standard8)]

Checked in:
http://hg.mozilla.org/releases/comm-aurora/rev/d59ce82bff2d
http://hg.mozilla.org/releases/comm-aurora/rev/985be5ac4630

Comment 12

[Mark Banner (:standard8)]

Checked in:
http://hg.mozilla.org/releases/comm-beta/rev/b1002bdd09b6
http://hg.mozilla.org/releases/comm-beta/rev/b0b116bdec07
http://hg.mozilla.org/releases/comm-esr10/rev/3b63dc8cfe1a
http://hg.mozilla.org/releases/comm-esr10/rev/4bb3fe25be5f

Comment 13

[Justin Wood (:Callek)]

To be clear, I'm a bit surprised you self-approved and used your approval for the suite/* changes here.

That said, I would have approved for suite had it been asked, so no end-result harm done.

Comment 14

[Mark Banner (:standard8)]

Sorry, I'd forgotten about the suite parts.