723243 - SimpleScaleGestureDetector uses getActionIndex(), which is not available in eclair

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: patch

This is just a convenience function which was introduced in Froyo. It is the equivalent of: 

(event.getAction() & MotionEvent.ACTION_POINTER_ID_MASK) >> MotionEvent.ACTION_POINTER_ID_SHIFT

but, ACTION_POINTER_ID_* was renamed to ACTION_POINTER_INDEX_* in Froyo, so I used those constants in the patch

Comment 1

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/6befd1389592

Comment 2

[Brad Lassey [:blassey] (use needinfo?)]

Comment on attachment 593554 [details] [diff] [review]
patch

[Approval Request Comment]
Regression caused by (bug #): 
User impact if declined: 
Crash when touching on eclair
Testing completed (on m-c, etc.): 
Risk to taking this patch (and alternatives if risky):
String changes made by this patch:

Comment 3

[Alex Keybl [:akeybl]]

Comment on attachment 593554 [details] [diff] [review]
patch

[Triage Comment]
Mobile only - approved for Aurora 12 and Beta 11.

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/49f5c924b7a5

Comment 5

[Brad Lassey [:blassey] (use needinfo?)]

https://hg.mozilla.org/releases/mozilla-beta/rev/02d946fad4c7

Comment 6

[Brad Lassey [:blassey] (use needinfo?)]

https://hg.mozilla.org/releases/mozilla-beta/rev/1e79aa665449

Comment 7

[Brad Lassey [:blassey] (use needinfo?)]

(In reply to Brad Lassey [:blassey] from comment #5)
> https://hg.mozilla.org/releases/mozilla-beta/rev/02d946fad4c7

this is actually bug 723151's patch