Closed Bug 72359 Opened 23 years ago Closed 21 years ago

Anonymous table cells get extra margins?

Categories

(Core :: Layout: Tables, defect)

Product:
Core
Component:
Layout: Tables
Type:
defect
Priority:
Not set
Severity:
minor

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla1.0.1

People

(Reporter: ian, Assigned: ian)

References

(
URL
)

Details

(Keywords: css2, testcase, Whiteboard: [Hixie-P4] [have fix])

Attachments

(1 file)

patch
414 bytes, patch
bernd_mozilla
: review+
dbaron
: superreview+
Details | Diff | Splinter Review 
It appears that the anonymous cell marked in the fragment below with "***" is
getting an extra margin.

  <float xmlns="http://www.example.org/">
   <!--table-->
    <!--row-->
     <cell>THERE</cell>
    <!--/row-->
    <row>
     <!--cell-->   <!-- *** -->
      <table>
       <!--row-->
        <cell>SHOULD B</cell>
        <cell>E N</cell>
        <cell>O RED</cell>
       <!--/row-->
      </table>
     <!--/cell-->
    </row>
    <cell>ANYWHERE</cell>
   <!--/table-->
  </float>

See http://www.hixie.ch/tests/adhoc/css/box/table/001.xml for a test case.
Note that until bug 72358 is fixed it will be hard to see this bug.
Depends on: 72358
Keywords: css2, mozilla1.0, testcase
Moving to m1.0
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla1.0
QA contact update
QA Contact: chrisd → amar
Depends on: 78695
Hyatt has a fix for this on his branch.
Assignee: karnaze → hyatt
Status: ASSIGNED → NEW
Whiteboard: [Hixie-P4]
Status: NEW → ASSIGNED
Target Milestone: mozilla1.0 → mozilla0.9.2
not fixed on branch, ->1.0
Target Milestone: mozilla0.9.2 → mozilla1.0
Incidentally, the fix is simply to remove the padding on :table-cell and move it
to the <td> rule. We just need the table folk to agree to it. Karnaze?
Whiteboard: [Hixie-P4] → [Hixie-P4] [have fix]
what's the status on this?
Target Milestone: mozilla1.0 → mozilla1.0.1
status?
Taking bug
Assignee: hyatt → ian
Status: ASSIGNED → NEW
ian, if you make this change, then you need to run the block and table 
regression tests.
you bet
Reconfirmed using FizzillaCFM/2002071208. Setting All/All.
OS: Windows 2000 → All
Hardware: PC → All
Attached patch patch — — Splinter Review 
we can safely remove this from ua.css as it is duplicated at html.css
http://lxr.mozilla.org/seamonkey/source/layout/html/document/src/html.css#231
and
http://lxr.mozilla.org/seamonkey/source/layout/html/document/src/html.css#238

I runned the regression tests:
the tests that failed are: 
http://lxr.mozilla.org/seamonkey/source/layout/html/tests/table/bugs/bug2479-1.html

 and the 2479-2 ...

http://lxr.mozilla.org/seamonkey/source/layout/html/tests/table/bugs/bug30985.html


the tests 2479-xx are made by hixie , so the probability that one will ever see
them in normal life is zero.
Attachment #124334 - Flags: superreview?(dbaron)
Attachment #124334 - Flags: review+
Attachment #124334 - Flags: superreview?(dbaron) → superreview+
fix + testcase checked in
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: