723618 - compile errors on Mac OS X 10.7 targeting 10.6 SDK

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Josh Aas]

Attachment: build log

Full log attached.

In file included from /Users/josh/src/mozilla/ff_trunk_debug_x86_64/dom/plugins/ipc/PluginUtilsOSX.mm:42:
In file included from /Users/josh/src/mozilla/ff_trunk_debug_x86_64/dom/plugins/ipc/PluginUtilsOSX.h:45:
In file included from ../../../dist/include/nsCoreAnimationSupport.h:49:
../../../dist/include/nsIOSurface.h:48:7: error: redefinition of 'NSOpenGLContext' as different kind of symbol
class NSOpenGLContext;

Comment 1

[Gregory Szorc [:gps]]

I'm seeing this as well. I also fingered bug 715785 as the root cause. Although, I haven't proved it.

This is the first time I haven't been able to build with the 10.7 SDK since 10.7 first came out (July 2011). Is backing out https://hg.mozilla.org/mozilla-central/rev/67b0e13d7a62 justified?

Comment 2

[Joe Drew (not getting mail)]

No, but we can fix this instead :)

Comment 4

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

I added a patch to bug 723738.
Should I just move it here?

Comment 5

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

Attachment: remove forward declaration

With this forward declaration the code reduces to

@interface NSOpenGLContext {
}
@end
class NSOpenGLContext;

which gcc accepts but clang intentionally rejects.

https://tbpl.mozilla.org/?tree=Try&rev=b8b6eed5b818

Comment 6

[Benoit Girard (:BenWa)]

Comment on attachment 593996 [details] [diff] [review]
remove forward declaration

I can review this. r+

Comment 7

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=8c6eab735db2

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/8c6eab735db2