Closed
Bug 723711
Opened 12 years ago
Closed 12 years ago
Return the profile data as JS objects
Categories
(Core :: Gecko Profiler, defect)
Tracking
()
RESOLVED
FIXED
mozilla13
People
(Reporter: jrmuizel, Assigned: jrmuizel)
Details
Attachments
(1 file)
10.28 KB,
patch
|
BenWa
:
review+
|
Details | Diff | Splinter Review |
This will be nicer to use and easier to extend.
Assignee | ||
Comment 1•12 years ago
|
||
Attachment #594193 -
Flags: review?(bgirard)
Comment 2•12 years ago
|
||
Comment on attachment 594193 [details] [diff] [review] Return JSObjects Review of attachment 594193 [details] [diff] [review]: ----------------------------------------------------------------- r+ based on us later moving JSBuilder.h ::: tools/profiler/sps/JSBuilder.h @@ +40,5 @@ > +/* this is handy wrapper around JSAPI to make it more pleasant to use. > + * We collect the JSAPI errors and so that callers don't need to */ > +class JSObjectBuilder > +{ > + public: Typically these are left aligned. @@ +141,5 @@ > + JSObjectBuilder(JSContext *aCx) : mCx(aCx), mOk(JS_TRUE) > + { > + } > + private: > + JSObjectBuilder(JSObjectBuilder&); You're not disallowing the evil assignment operator.
Attachment #594193 -
Flags: review?(bgirard) → review+
Comment 3•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/c433e993506b
Assignee: nobody → jmuizelaar
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla13
Comment 4•12 years ago
|
||
hm, looks like this has been backed out but not annotated
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Target Milestone: mozilla13 → ---
Comment 5•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/2ee344ca2759
Status: REOPENED → RESOLVED
Closed: 12 years ago → 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla13
You need to log in
before you can comment on or make changes to this bug.
Description
•