Closed Bug 723746 Opened 12 years ago Closed 12 years ago

regression: XUL Fennec uses non-tablet layout on ICS tablets

Categories

(Firefox for Android Graveyard :: General, defect)

Product:
Firefox for Android Graveyard
Component:
General
Version:
Firefox 13
Platform:
All
Android
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox11 fixed, firefox12 fixed, firefox13 fixed, firefox-esr1012+ verified, fennec11+)

Status:
RESOLVED FIXED
Milestone:
Firefox 13
Tracking Flags:
Tracking Status
firefox11 --- fixed
firefox12 --- fixed
firefox13 --- fixed
firefox-esr10 12+ verified
fennec 11+ ---

People

(Reporter: mbrubeck, Assigned: mbrubeck)

References

Details

(Keywords: regression)

Attachments

(1 file)

patch
929 bytes, patch
mfinkle
: review+
akeybl
: approval-mozilla-aurora+
akeybl
: approval-mozilla-beta+
lsblakk
: approval-mozilla-esr10+
Details | Diff | Splinter Review
Attached patch patch — — Splinter Review 
Regression from bug 671634, which changed an nsSystemInfo property from "isTablet" to "tablet" without updating the existing code that used the property.
Attachment #593993 - Flags: review?(mark.finkle)
Attachment #593993 - Flags: review?(mark.finkle) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/eddcf32f7b6f
Whiteboard: [has patch]
Target Milestone: --- → Firefox 13
Comment on attachment 593993 [details] [diff] [review]
patch

[Approval Request Comment]
Regression caused by (bug #): bug 671634

User impact if declined: Firefox uses non-tablet on tablets running Android 4.

Testing completed (on m-c, etc.): Landed on inbound Februrary 2.

Risk to taking this patch (and alternatives if risky):  Extremely low risk. Trivial (one-line) XUL-fennec-only patch to fix an obvious regression.

String changes made by this patch: None.

Note: This patch should land on Aurora/Beta at the same time as bug 671634.
Attachment #593993 - Flags: approval-mozilla-beta?
Attachment #593993 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/eddcf32f7b6f
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Comment on attachment 593993 [details] [diff] [review]
patch

[Triage Comment]
Approved for Aurora 12 and Beta 11.
Attachment #593993 - Flags: approval-mozilla-beta?
Attachment #593993 - Flags: approval-mozilla-beta+
Attachment #593993 - Flags: approval-mozilla-aurora?
Attachment #593993 - Flags: approval-mozilla-aurora+
Comment on attachment 593993 [details] [diff] [review]
patch

Requesting approval-mozilla-esr10 because this patch blocks bug 671634.  See bug 671634 comment 94 for details.
Attachment #593993 - Flags: approval-mozilla-esr10?
Comment on attachment 593993 [details] [diff] [review]
patch

[Triage Comment]
Android-only, low risk
Attachment #593993 - Flags: approval-mozilla-esr10? → approval-mozilla-esr10+
Tablet layout display on Asus Eee Transformers (Android 4.0.3) on build: Mozilla/5.0 (Android; Tablet; rv:10.0.4esrpre) Gecko/10.0.4es Firefox/10.0.4esrpre Fennec/10.0.4esrpre
status-firefox-esr10: fixed → verified
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: