723970 - Backout Bug 698187 due to mozilla-central back out of parts of bug 698986 to resolve bug 716945.

Status: RESOLVED FIXED

(SeaMonkey :: General, defect)

Description

[Philip Chee]

Mozilla-central plans to backout out parts of bug 698986 to resolve bug 716945.
q.v.:
Bug 716945 - Figure out why Flash hang volume dropped very significantly in 10.0a1 trunk on 2011-10-29
Bug 665196 - Change in-content plugin crash UI to submit a crash report and reload the page in one step.
SM Bug 698187 Sync pluginCrashedUI with changes from Firefox (Bug 665196 and Bug 688083)

Comment 1

[Robert Kaiser]

FYI, this has already been backed out from Firefox 11 (now Beta).

Comment 2

[Philip Chee]

Attachment: Patch v1.0 Backout.

Attaching patch for check-in for when m-c backs out their core patch.

Comment 3

[Philip Chee]

Comment on attachment 594205 [details] [diff] [review]
Patch v1.0 Backout.

> FYI, this has already been backed out from Firefox 11 (now Beta).
In that case, asking for approval for comm-beta (SeaMonkey 2.8)

Comment 4

[Serge Gautherie (:sgautherie)]

Hum, why is this bug marked "status-seamonkey2.7: fixed"? And don't we want approval-comm-aurora too/first?

Comment 5

[Philip Chee]

> Hum, why is this bug marked "status-seamonkey2.7: fixed"?
I must have forgotten to reset the flags when I cloned the bug.
> And don't we want approval-comm-aurora too/first?
Only if MoCo backs out the underlying patch from mozilla-aurora.

Comment 6

[Philip Chee]

Comment on attachment 594205 [details] [diff] [review]
Patch v1.0 Backout.

> Only if MoCo backs out the underlying patch from mozilla-aurora.
Bug 716945 Comment 25 has approval for mozilla-aurora.
Asking for comm-aurora.

Comment 7

[Ian Neal]

(In reply to Philip Chee from comment #6)
> Comment on attachment 594205 [details] [diff] [review]
> Patch v1.0 Backout.
> 
> > Only if MoCo backs out the underlying patch from mozilla-aurora.
> Bug 716945 Comment 25 has approval for mozilla-aurora.
> Asking for comm-aurora.

Do we have a way of making flash crash so we can see if we fail at submitting too?

Comment 8

[Philip Chee]

> Do we have a way of making flash crash so we can see if we fail at submitting too?
In Win7 I used the task manager to kill the plugin container.

Comment 9

[Philip Chee]

The underlying bug was backed out of mozilla-central: https://hg.mozilla.org/mozilla-central/rev/2087f423a1a4
We need to do the same for suite.

Comment 10

[Robert Kaiser]

Yes, this has been backed out of all non-release channels now, i.e. Mozilla toolkit 11 and higher.

Comment 11

[Philip Chee]

Pushed to comm-central:
http://hg.mozilla.org/comm-central/rev/243b4f14dab8

Still needs approval for comm-aurora and comm-central!

Comment 12

[Justin Wood (:Callek)]

Comment on attachment 594205 [details] [diff] [review]
Patch v1.0 Backout.

I didn't verify that the m-c bug was backed out on these branches, but assuming it was, land away.

Comment 13

[Philip Chee]

REOPENED Still needs to land on comm-beta and comm-aurora.

> I didn't verify that the m-c bug was backed out on these branches
According to KaiRo, it was.

Comment 14

[Serge Gautherie (:sgautherie)]

(In reply to Philip Chee from comment #13)
> REOPENED Still needs to land on comm-beta and comm-aurora.

Main 'Status' is for m-c; 'status-seamonkey*' are for branches:
so current status of this bug should actually be "Fixed"...

Comment 15

[Philip Chee]

I'm keeping this open to remind *ME* to check this in to the branches.

Comment 16

[Philip Chee]

Pushed to comm-aurora:
http://hg.mozilla.org/releases/comm-aurora/rev/58d020405ee4
Pushed to comm-beta:
http://hg.mozilla.org/releases/comm-beta/rev/9f3e1bfd37aa