Closed
Bug 724145
Opened 12 years ago
Closed 12 years ago
telemetry for search hijacking
Categories
(Firefox :: General, defect)
Firefox
General
Tracking
()
RESOLVED
FIXED
Firefox 13
People
(Reporter: Gavin, Assigned: Gavin)
References
Details
(Whiteboard: [qa-])
Attachments
(1 file)
2.59 KB,
patch
|
jaws
:
review+
akeybl
:
approval-mozilla-aurora+
akeybl
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
See bug 718088. We'd like to gather some preliminary telemetry data to try and gauge how common it is for users to have user-set values for keyword.URL.
Assignee | ||
Comment 1•12 years ago
|
||
This is the simple first step - just indicate whether there's a user-set value or not.
Comment 2•12 years ago
|
||
Comment on attachment 594355 [details] [diff] [review] patch Review of attachment 594355 [details] [diff] [review]: ----------------------------------------------------------------- Looks good to me. Thanks for requesting review :)
Attachment #594355 -
Flags: review?(jwein) → review+
Assignee | ||
Comment 3•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/841b4395aa66
Target Milestone: --- → Firefox 13
Comment 4•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/841b4395aa66
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 5•12 years ago
|
||
Comment on attachment 594355 [details] [diff] [review] patch I'd like to take this on Aurora/Beta to get some more data before we move on to implementation in bug 718088. Risk is very low, it's just a simple pref check and telemetry addition. No string changes.
Attachment #594355 -
Flags: approval-mozilla-beta?
Attachment #594355 -
Flags: approval-mozilla-aurora?
Comment 6•12 years ago
|
||
Comment on attachment 594355 [details] [diff] [review] patch [Triage Comment] Telemetry additions are high-reward and low-risk, so approving for Aurora 12 and Beta 11.
Attachment #594355 -
Flags: approval-mozilla-beta?
Attachment #594355 -
Flags: approval-mozilla-beta+
Attachment #594355 -
Flags: approval-mozilla-aurora?
Attachment #594355 -
Flags: approval-mozilla-aurora+
Assignee | ||
Comment 7•12 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/3979dbbde70e https://hg.mozilla.org/releases/mozilla-beta/rev/2fd8b0dffd5a
status-firefox11:
--- → fixed
status-firefox12:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•