Closed
Bug 724256
Opened 12 years ago
Closed 12 years ago
Optimize move file calls on Windows, saving about 2ms per call (1 call on startup)
Categories
(Core :: XPCOM, defect)
Tracking
()
RESOLVED
FIXED
mozilla13
People
(Reporter: bbondy, Assigned: bbondy)
References
Details
Attachments
(1 file)
|
1.12 KB,
patch
|
benjamin
:
review+
|
Details | Diff | Splinter Review |
In 2007, bug 375778 added the flag MOVEFILE_WRITE_THROUGH. This flag wasn't needed by the description of the problem in that bug though. This flag causes the cache manager to flush the data to disk before returning. There is no benefit as far as consistency of the file data with subsequent calls though and we shouldn't do it from our file API because it incurs a cost of ~2ms.
Attachment #594445 -
Flags: review?(benjamin)
|
||
Updated•12 years ago
|
Attachment #594445 -
Flags: review?(benjamin) → review+
|
Assignee | |
Comment 1•12 years ago
|
||
http://hg.mozilla.org/integration/mozilla-inbound/rev/8787499fae84
Target Milestone: --- → mozilla13
|
||
Comment 2•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/8787499fae84
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•