724377 - Visited add-on (preliminary reviewed version 0.093) causes immortal zombie chrome compartments

Status: RESOLVED FIXED

(WebExtensions :: General, defect)

Description

[Andreas Wagner [:TheOne] [use NI]]

This add-on leaks chome compartments.

STR:

1) Install the add-on from the url above
2) Go to any webpage you with already visited links (I used youtube.com).
3) Press ALT+V do activate the add-on
2) Close tab and disable the add-on
4) Go to about:memory?verbose and click <minimize memory usage>
5) The add-on is still listed on about:memory

The author has been informed about this bug.

Comment 1

[Nicholas Nethercote [inactive]]

Which version is this?

If this is dependent on bug 724404, does that mean that when that bug is fixed the leak will be gone?  If so, I don't know if we need this bug, it would probably suffice to record which add-ons are affected in bug 724404.

Comment 2

[[e-mail]]

My Visited 0.093 use Addon-kit 1.3 with this modules: 
self, hotkeys, widget, page-mod, tabs, and notifications

I will try to fix this bug, thank you.

Comment 3

[Nicholas Nethercote [inactive]]

(In reply to [e-mail] from comment #2)
> My Visited 0.093 use Addon-kit 1.3 with this modules: 
> self, hotkeys, widget, page-mod, tabs, and notifications

As bug 724404 indicates, it might be the widget module that's causing the leak.

Comment 4

[Jorge Villalobos [:jorgev] (he/him)]

Zig, version 1.5 of the SDK is now available. Please rebuild your add-on using this version and submit it to AMO, so we can check if the leaks are fixed.

Comment 5

[[e-mail]]

Today, I use SDK ver 1.5 but it is still listed on about:memory. I will try to fix soon.

I found some bug with widget.
When I install more then one addons that use widget. The addon bar will auto show in new window.

1) Install two addons that use widget. 
2) Press CTRL+/ to close addon bar.
3) Open new window.
2) Addon bar will auto show.

Thank you.

Comment 6

[[e-mail]]

I test SDK 1.5 with "Test Zombie" v.12 but it still be zombie.
https://builder.addons.mozilla.org/addon/1041626/revision/12/

I found cause is module name "widget" and "tabs".

When I comment widget and tabs, this addon isn't listed on about:memory.
https://builder.addons.mozilla.org/addon/1041626/revision/13/

Comment 7

[Jorge Villalobos [:jorgev] (he/him)]

According to bug 730566 comment #5, some SDK leaks are still present.

Comment 8

[Jorge Villalobos [:jorgev] (he/him)]

ZIG: version 1.6 of the SDK was released and it addresses all known memory leaks. Please rebuild your add-on with the 1.6 SDK and submit an update so we can test it again.

Comment 9

[Jorge Villalobos [:jorgev] (he/him)]

The developer has been contacted again through the editor tools.

Comment 10

[[e-mail]]

I tested it on 1.6 but I see it still be zombie. I'm trying to find couse.
But now my computer that have tested code has a trouble.
I will submit update soon.
Thank you.

Comment 11

[Jorge Villalobos [:jorgev] (he/him)]

Do you have any updates on this, Zig?

Comment 12

[[e-mail]]

(In reply to Jorge Villalobos [:jorgev] from comment #11)
> Do you have any updates on this, Zig?

I will update as soon as possible. Thanks for wait.

Comment 13

[Andrew Williamson [:eviljeff]]

Zig: we just need you to repack with the latest version of the SDK, 1.6.1 and upload a new version.  If the leak is still there we'll have a look into it but at the moment we can't discount known leaks in earlier versions of the SDK.

If we don't see an update by the end of next week we'll have to downgrade your listing to reduce the impact on users.

Comment 14

[[e-mail]]

Attachment: Visited 0.10b.rev123

Comment 15

[[e-mail]]

Sorry for my late.

I attach Visited 0.10b.rev123
This version use SDK 1.7

I see "jid0-xgzydxpakrowmumfwkinyrxigba-at-jetpack/api-utils/lib/traceback.js" still be zombie.

Comment 16

[Jorge Villalobos [:jorgev] (he/him)]

Alex, I think this is another potential problem in the SDK.

Comment 17

[Jorge Villalobos [:jorgev] (he/him)]

Zig, can you try again with the latest SDK?

Comment 18

[[e-mail]]

Attachment: Visited 0.2b

I test with SDK 1.9 and after I disable it and call GC, I see 

compartment([System Principal], resource://jid0-xgzydxpakrowmumfwkinyrxigba-at-jetpack/addon-kit/lib/notifications.js, 0x9ee6000)

compartment([System Principal], jar:file:///C:/Users/XXXXX/AppData/Roaming/Mozilla/Firefox/Profiles/XXXXX.default/extensions/[e-mail]!/bootstrap.js, 0x9bf9000)

still be zombies.

Comment 19

[[e-mail]]

If I enable it after start Firefox then disable and call GC, I see 

compartment([System Principal], resource://jid0-xgzydxpakrowmumfwkinyrxigba-at-jetpack/api-utils/lib/traceback.js, 0x92ca000)

compartment([System Principal], jar:file:///C:/Users/XXXXX/AppData/Roaming/Mozilla/Firefox/Profiles/XXXXX.default/extensions/[e-mail]!/bootstrap.js, 0x886e000)

still be zombies.

Comment 20

[Kris Maglione [:kmag]]

I don't see zombie compartments with the latest release on Firefox 16. Calling this fixed. You should nonetheless repack with the latest Jetpack release.