724499 - TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/suite/browser/test/browser_pluginnotification.js | Test timed out

Status: VERIFIED FIXED

(SeaMonkey :: UI Design, defect)

Description

[Philip Chee]

Oh dearie me! I forgot to port the test changes when I did Bug 667201 (Front end changes for Bug 545070: plugin-problem UI shouldn't say "click here").

Comment 1

[Philip Chee]

Attachment: Patch v1.0 Fix test.

Before patch:

> mochitest-browser-chrome failed:
> TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/suite/browser/test/browser_pluginnotification.js | Test timed out
> TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/suite/browser/test/browser_pluginnotification.js | Found a tab after previous test timed out: chrome://mochitests/content/browser/suite/browser/test/plugin_test.html
> TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/suite/browser/test/browser_pluginnotification.js | an unexpected uncaught JS exception reported through window.onerror - executeSoon is not defined at chrome://mochitests/content/browser/suite/browser/test/browser_pluginnotification.js:92

After patch:

> INFO TEST-START | Shutdown
> Browser Chrome Test Summary
>         Passed: 450
>         Failed: 0
>         Todo: 3
> 
> *** End BrowserChrome Test Results ***

Comment 2

[Philip Chee]

Comment on attachment 594667 [details] [diff] [review]
Patch v1.0 Fix test.

Bah silly bugzilla. Hope r?=IanN works this time.

Comment 3

[Ian Neal]

Comment on attachment 594667 [details] [diff] [review]
Patch v1.0 Fix test.

r=me assuming serge gives positive feedback

Comment 4

[Serge Gautherie (:sgautherie)]

Comment on attachment 594667 [details] [diff] [review]
Patch v1.0 Fix test.

Review of attachment 594667 [details] [diff] [review]:
-----------------------------------------------------------------

Sure, trivial copy+paste :-)

While here, in browser_pluginnotification.js, could you try+update
-  var tags = ph.getPluginTags({});
+  var tags = ph.getPluginTags();
too, which should be enough for SM too.

Comment 5

[Philip Chee]

Pushed to comm-central:
http://hg.mozilla.org/comm-central/rev/5ab177f7e555

Comment 6

[Serge Gautherie (:sgautherie)]

http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1328632854.1328639066.12467.gz&fulltext=1
WINNT 5.2 comm-central-trunk debug test mochitest-other on 2012/02/07 08:40:54
{
INFO TEST-END | chrome://mochitests/content/browser/suite/browser/test/browser_pluginnotification.js | finished in 8432ms
}

V.Fixed.

Comment 7

[Serge Gautherie (:sgautherie)]

Comment on attachment 594667 [details] [diff] [review]
Patch v1.0 Fix test.

"approval-comm-aurora=?":
"approval-comm-beta=?":
Test-only, no risk.
Fixes a (30s) timeout, and possibly other tests.

Comment 8

[Justin Wood (:Callek)]

http://hg.mozilla.org/releases/comm-beta/rev/cbb86a50dfca

Comment 9

[Serge Gautherie (:sgautherie)]

http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey-Beta/1331186022.1331189779.1265.gz
OS X 10.5 comm-beta debug test mochitest-other on 2012/03/07 21:53:42

seamonkey2.8: verified.

***

Philip, can you push to c-a?

Comment 10

[Philip Chee]

Pushed to comm-aurora:
http://hg.mozilla.org/releases/comm-aurora/rev/2da24b86b1fb

Comment 11

[Serge Gautherie (:sgautherie)]

http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey-Aurora/1331290603.1331295719.18112.gz
OS X 10.6 comm-aurora debug test mochitest-other on 2012/03/09 02:56:43

seamonkey2.9: verified.